phpBB

Development Discussion Board

phpBB's testing ground of bleeding edge code
Advanced search

Improvement to template::display hook

Discussion of general topics related to the new version and its place in the world. Don't discuss new features, report bugs, ask for support, et cetera. Don't use this to spam for other boards or attack those boards!
Forum rules
Discussion of general topics related to the new release and its place in the world. Don't discuss new features, report bugs, ask for support, et cetera. Don't use this to spam for other boards or attack those boards!

Improvement to template::display hook

Postby igorw » Tue Oct 12, 2010 2:22 pm

The template::display hook has a major issue: You do not get access to the template instance. Just using the $template global used to be fine, but now the email system also uses the template system internally. This leads many things to break.

The solution to this would be to pass the template instance ($this) into the hooks. This would be an additional argument, and I'm pretty sure it would be backward-compatible.

It would be nice if we could fix this for 3.0.8 or 3.0.9, are there any reasons not to do so?
User avatar
igorw
Registered User
 
Posts: 500
Joined: Thu Jan 04, 2007 11:47 pm

Return to [3.0/Olympus] Discussion

Who is online

Users browsing this forum: No registered users and 11 guests