phpBB

Development Discussion Board

phpBB's testing ground of bleeding edge code
Advanced search

Drop php closing tags

Discussion of general topics related to the new version and its place in the world. Don't discuss new features, report bugs, ask for support, et cetera. Don't use this to spam for other boards or attack those boards!
Forum rules
Discussion of general topics related to the new release and its place in the world. Don't discuss new features, report bugs, ask for support, et cetera. Don't use this to spam for other boards or attack those boards!

Re: Drop php closing tags

Postby igorw » Fri Jun 25, 2010 11:28 pm

I know none except for the install files. Give me a use case where a MOD would look for a ?> that is not the EOF.
User avatar
igorw
Registered User
 
Posts: 500
Joined: Thu Jan 04, 2007 11:47 pm

Re: Drop php closing tags

Postby igorw » Sat Sep 04, 2010 8:44 am

I am bumping this. For new files the ?> is being dropped (this was adjusted in the coding guidelines), however it has not yet been decided how to handle existing files.

I'm still in favour of adjusting the existing files for 3.1.
User avatar
igorw
Registered User
 
Posts: 500
Joined: Thu Jan 04, 2007 11:47 pm

Re: Drop php closing tags

Postby imkingdavid » Tue Sep 07, 2010 2:36 am

eviL3 wrote:I'm still in favour of adjusting the existing files for 3.1.

This.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.
User avatar
imkingdavid
Development Team
Development Team
 
Posts: 906
Joined: Thu Jul 30, 2009 12:06 pm

Re: Drop php closing tags

Postby APTX » Sun Sep 12, 2010 3:08 am

eviL3 wrote:I'm still in favour of adjusting the existing files for 3.1.

Yes!
Don't give me my freedom out of pity!
APTX
Registered User
 
Posts: 680
Joined: Thu Apr 24, 2003 12:07 pm

Re: Drop php closing tags

Postby igorw » Sun Sep 12, 2010 1:33 pm

Added a patch to the ticket.
User avatar
igorw
Registered User
 
Posts: 500
Joined: Thu Jan 04, 2007 11:47 pm

Re: Drop php closing tags

Postby 3Di » Wed Oct 13, 2010 3:43 pm

igorw wrote:I know none except for the install files. Give me a use case where a MOD would look for a ?> that is not the EOF.

the Pastebin MOD, while using the PHP Syntax Highlighter, searchs for SCRIPT_DELIMITERS, in this case searching for it also and not only.
Give Peace A Chance.. Pass ON It! ° phpBB wiki in Italiano ° Ich bin ein Berliner
Image
User avatar
3Di
 
Posts: 467
Joined: Tue Nov 01, 2005 9:50 pm
Location: Berlin - Milan

Previous

Return to [3.0/Olympus] Discussion

Who is online

Users browsing this forum: No registered users and 16 guests