Remove duplicate css of stylesheet files

[Raimon]

As per [RFC|Accepted] No db storage of themes and stylesheets it might also be useful to increase the size of all the stylesheet files

Currently the stylesheet contains a lot of duplicate css, what really not make any sense.

For example ;

content.css

Code: Select all

li.row:hover {
   background-color: #f6f6f6;
}

colours.css

Code: Select all

li.row:hover {
   background-color: #F6F4D0;
}

I can imagine that we can not reduce it to one file since that would be give some problems to Custom Styles, that would be something for 4.0 i think, but general it should be possible to remove those duplicate content that is not used by prosilver, like the example above.

Any thoughts about this?

[ameeck]

I completely agree with this.

While separating the content into different files and setting dimensions and content flow in one and adding colors in another is fine, setting them at both places and rewriting them is redundant and should be removed.

[rahber]

+1

it would be great.

just one thing isn't it good to have all style attributes in one file?
because it may get difficult for a newbie to sort things out in different files ?

[A_Jelly_Doughnut]

I'd like to do something like this, but identifying the duplicates will be challenging at best. Probably the best way to do so would be to write (or borrow) a parser for the CSS files.

Anyone know of some application that would make this easier?

[Jhong]

firebug should be good enough -- it can show you the resultant CSS for the page.

A big +1 for combining the CSS into a single file (with a separate file for IE-specific hacks). It will make mods and administration much easier.

[A_Jelly_Doughnut]

A big +1 for combining the CSS into a single file (with a separate file for IE-specific hacks). It will make mods and administration much easier.

That wasn't the proposal, as far as I understood it. What I understood from Raimon was to remove the CSS which is later contradicted by other CSS. And if that is the case, Firebug is of no help because it only shows the CSS which is in effect.

[Jhong]

Yes, the +1 was in response to rahber's comment. Digging through multiple CSS files is a pain.

If Firebug won't work, CSS Tidy might do the trick: http://csstidy.sourceforge.net/

I also wrote a CSS parser class ("CSS magic") for WP-United that parses CSS, performs operations (modifies selector specificity -- you don't need this) and then spits out the result: http://www.wp-united.com/svn/0.8.5/root ... -magic.php . However, it doesn't combine duplicate selectors (on purpose; CSS order can be important). It would be very easy to modify the addSelector() function to combine duplicates, but you'd also want to split selectors by ',' earlier than CSS Magic does it. You're welcome to use it... (gpl, usage examples at the top), but I expect a pre-built tool like CSS Tidy might work without any modification.

[prototech]

I've created a task for this in the tracker: http://tracker.phpbb.com/browse/PHPBB3-9794

[Mighty Gorgon]

This topic is a bit old... but I agree on the proposal about cleaning up CSS from duplicated color attributes.