phpBB

Development Discussion Board

phpBB's testing ground of bleeding edge code
Advanced search

[RFC|Merged] Rename MSNM to WLM

These requests for comments have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
Post Reply

[RFC|Merged] Rename MSNM to WLM

Postby nickvergessen » Mon Jul 12, 2010 12:54 pm

As per viewtopic.php?f=3&t=24122 I think we should do this for 3.1

Pull Request: https://github.com/phpbb/phpbb3/pull/23
cheers nickvergessen :geek:
Member of phpBB Development-Team
No Support via PM — My MODs for phpBB 3.0.x
User avatar
nickvergessen
Development Team
Development Team
 
Posts: 357
Joined: Sun Oct 07, 2007 11:54 am
Location: Esslingen, Germany
Top

Re: [RFC] Rename MSNM to WLM

Postby EXreaction » Mon Jul 12, 2010 4:41 pm

Please do not rename the column in the database, that's just asking for compatibility problems. :/

Changing the language value and image should be enough.
My phpBB3 Mods: Advertisement Management | User Blog Mod | Anti-Spam ACP | Advanced Subscriptions | One Click Ban | From Author PM List | FAQ Manager | Forum Sponsors | Soft Delete | Auto Database Backup | Drag 'n Drop Forum List | HTML Ranks | Enable HTML
User avatar
EXreaction
Development Team
Development Team
 
Posts: 1274
Joined: Sat Sep 10, 2005 2:15 am
Top

Re: [RFC] Rename MSNM to WLM

Postby igorw » Mon Jul 12, 2010 5:12 pm

I agree with nathan. While it would be nice to have it all cleaned, it does not justify the cost (upgrade pains, compatibility with MODs...). IMO not worth it.
User avatar
igorw
Registered User
 
Posts: 500
Joined: Thu Jan 04, 2007 11:47 pm
Top

Re: [RFC] Rename MSNM to WLM

Postby naderman » Sun Jul 18, 2010 2:13 pm

I agree with Igor and Nathan on this.
www.naderman.de
Move your forum to Forumatic - we'll take care of maintenance & spam
User avatar
naderman
Development Team Leader
Development Team Leader
 
Posts: 1650
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Top

Re: [RFC] Rename MSNM to WLM

Postby naderman » Mon Jul 19, 2010 3:13 pm

Alright so this is accepted, but without the column name change. So UI only.
www.naderman.de
Move your forum to Forumatic - we'll take care of maintenance & spam
User avatar
naderman
Development Team Leader
Development Team Leader
 
Posts: 1650
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Top

Re: [RFC|Accepted] Rename MSNM to WLM

Postby nickvergessen » Tue Aug 03, 2010 6:44 pm

Ticket: http://tracker.phpbb.com/browse/PHPBB3-6109
Branch: http://github.com/nickvergessen/phpbb3/ ... icket/6109

Ready for merge...
cheers nickvergessen :geek:
Member of phpBB Development-Team
No Support via PM — My MODs for phpBB 3.0.x
User avatar
nickvergessen
Development Team
Development Team
 
Posts: 357
Joined: Sun Oct 07, 2007 11:54 am
Location: Esslingen, Germany
Top

Re: [RFC|Accepted] Rename MSNM to WLM

Postby ToonArmy » Fri Aug 06, 2010 7:47 pm

The image doesn't look right to me.
Chris Smith • Blog • XMO • Ohloh • Area51 • Wiki • No support via PM/IM
Image
User avatar
ToonArmy
Registered User
 
Posts: 335
Joined: Fri Mar 26, 2004 7:31 pm
Location: Bristol, UK
Top

Re: [RFC|Accepted] Rename MSNM to WLM

Postby naderman » Sat Aug 07, 2010 2:31 am

Mind explaining that?
www.naderman.de
Move your forum to Forumatic - we'll take care of maintenance & spam
User avatar
naderman
Development Team Leader
Development Team Leader
 
Posts: 1650
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Top

Re: [RFC|Accepted] Rename MSNM to WLM

Postby ToonArmy » Sat Aug 07, 2010 11:39 am

naderman wrote:Mind explaining that?

The prosilver shades look wrong, probably just my eyes and monitors.
Chris Smith • Blog • XMO • Ohloh • Area51 • Wiki • No support via PM/IM
Image
User avatar
ToonArmy
Registered User
 
Posts: 335
Joined: Fri Mar 26, 2004 7:31 pm
Location: Bristol, UK
Top

Re: [RFC|Accepted] Rename MSNM to WLM

Postby naderman » Sat Aug 07, 2010 1:11 pm

I guess, looks alright to me.
www.naderman.de
Move your forum to Forumatic - we'll take care of maintenance & spam
User avatar
naderman
Development Team Leader
Development Team Leader
 
Posts: 1650
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Top
Next
Post Reply

Return to [3.1/Ascraeus] Merged RFCs

Who is online

Users browsing this forum: Bing [Bot] and 9 guests

Powered by phpBB® Forum Software © phpBB Group
Time : 0.663s | 14 Queries | GZIP : On
 

Loading

Please wait.