phpBB

Development Discussion Board

phpBB's testing ground of bleeding edge code
Advanced search

[RFC|Rejected] Removal of subsilver2

These RFCs were either rejected or have been replaced by an alternative proposal. They will not be included in phpBB.

Re: subsilver2

Postby imkingdavid » Sat Apr 03, 2010 4:33 pm

And of course any template can be adapted to 3.1 after the fact, so even if it's not supported by the phpBB team officially, someone is bound to update it and release it.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.
User avatar
imkingdavid
Development Team
Development Team
 
Posts: 900
Joined: Thu Jul 30, 2009 12:06 pm

Re: subsilver2

Postby naderman » Sat Apr 03, 2010 5:35 pm

Well I think it is decided then. I will remove subsilver2 from the develop branch.
www.naderman.de
Move your forum to Forumatic - we'll take care of maintenance & spam
User avatar
naderman
Development Team Leader
Development Team Leader
 
Posts: 1649
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany

Re: subsilver2

Postby Alpha Trion » Tue Apr 06, 2010 7:08 pm

My opinion is this:

Users need a clean style, easy to modify and have the look of subsilver (you know with the category header, category footer)!

I know this from first hand as whatever skin i design i follow the template of subsilver2 and people just love it!

I have design x-silver based on prosilver but with the classic look of subsilver2. This is the combination that people love! Including me offcourse!

I think prosilver should be redesigned a little. There are many things inside it that don't work well or it is very difficult to change.

For example if someone try to modify the posting template faces a whole board distruction because there are 4 ( i think) files that being used for the posting template of NEW TOPIC - POST REPLY - NEW PM - SHOW DRAFTS.

You change something and works ok in NEW TOPIC posting template but it ruins the COMPOSE PM posting template.

That was just an example! We need to make it more simple. One file for drafts, one for PM's, one for New Topic - Post Reply. Generally we need to make it simpler to modify.


Excuse me if i judge things but i really want to help in every way i can and i am fully support phpbb community. Trust me on this, if we built a subsilver3 (prosilver with a cleaner code with subsilver look) it will be the best skin ever.
Alpha Trion
Registered User
 
Posts: 1
Joined: Tue Apr 06, 2010 6:57 pm

Re: subsilver2

Postby keith10456 » Wed Apr 07, 2010 5:29 pm

naderman wrote:Well I think it is decided then. I will remove subsilver2 from the develop branch.


Glad to hear it!
User avatar
keith10456
Registered User
 
Posts: 259
Joined: Sat Apr 22, 2006 10:29 pm

Re: subsilver2

Postby pixel » Sat May 15, 2010 9:11 am

Ashley.S. wrote:I think subsilver2 should be dropped and someone should try and turn it into a proSilver based style

there's one in development here : http://www.flash-paradise.net/demo/index.php?style=51
pixel
Registered User
 
Posts: 5
Joined: Wed Nov 26, 2008 1:02 am

Re: subsilver2

Postby naderman » Sun May 16, 2010 7:02 pm

www.naderman.de
Move your forum to Forumatic - we'll take care of maintenance & spam
User avatar
naderman
Development Team Leader
Development Team Leader
 
Posts: 1649
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany

Re: subsilver2

Postby Wickedlad » Mon May 17, 2010 6:47 am

naderman wrote:My view on subsilver2:

  • It causes extra work during development, that is not helping phpBB's main goal of becoming a better forum software
  • It causes extra work for MOD authors to support two very different templates - many don't even bother support both templates
  • Keeping two very different base templates up to date with MODs is a lot of work for users

So I agree that the best choice would be to get rid of it. We can still look into building a subsilver3 with CSS and some very few template changes with most stuff inherited.


I totally agree with you, especially the second one.
Wickedlad
Registered User
 
Posts: 3
Joined: Tue Jun 19, 2007 12:20 pm

Re: subsilver2

Postby leviatan21 » Tue Jun 29, 2010 7:54 pm

If someone want to hear my opinion here it is :

Subsiver2 is newbie user friendly : when I move my phpbb 2x to 3x I hate prosilver, but just because I never use something like that, now after some time and modifications I like it and find subsilver2 awful to use.
Most other people I help, have the same looking :roll:

About those 70.000 statistics, IMO is not useful, it tell you which style have the user when he install a board, mostly install phpbb with the standard style and then, he can add a new one, same for languages ;)

If the style.php can be improved and do the css parse better ( probably using more the template engine ) would be great and the http://www.flash-paradise.net/demo/index.php?style=51 is a good example.

One other issue I found using prosiver style is that sometimes having more than a couple of float, it mostly happens on the index page, where the forum image, descriptions and the rss link can be a mess when it do not load quickly, it is solver by refreshing the page, but is a kinda annoying :roll: .
QA Team Member - I don't support by PM,
Customize forums, install Skins/Mods ! Sendme a PM | Don't forget to visit my other mods
Excuse me for my poor English, I speak Spanish. | Image phpBB en Español
leviatan21
Registered User
 
Posts: 18
Joined: Tue May 05, 2009 5:51 pm

Re: subsilver2

Postby tuananhdnc » Thu Jul 22, 2010 1:25 am

Alpha Trion wrote:My opinion is this:

Users need a clean style, easy to modify and have the look of subsilver (you know with the category header, category footer)!

I know this from first hand as whatever skin i design i follow the template of subsilver2 and people just love it!

I have design x-silver based on prosilver but with the classic look of subsilver2. This is the combination that people love! Including me offcourse!

I think prosilver should be redesigned a little. There are many things inside it that don't work well or it is very difficult to change.

For example if someone try to modify the posting template faces a whole board distruction because there are 4 ( i think) files that being used for the posting template of NEW TOPIC - POST REPLY - NEW PM - SHOW DRAFTS.

You change something and works ok in NEW TOPIC posting template but it ruins the COMPOSE PM posting template.

That was just an example! We need to make it more simple. One file for drafts, one for PM's, one for New Topic - Post Reply. Generally we need to make it simpler to modify.


Excuse me if i judge things but i really want to help in every way i can and i am fully support phpbb community. Trust me on this, if we built a subsilver3 (prosilver with a cleaner code with subsilver look) it will be the best skin ever.


I agree with your comments, but Subsilver remake from Prosilver is not a perfect solution.
Many people need one style look like Subsilver with new core, I imagine it will have some feature as:
Tabless layout
Clean and optimize coding
Popular user friendly
Easy customize
tuananhdnc
Registered User
 
Posts: 1
Joined: Tue Jul 20, 2010 3:59 pm

Re: subsilver2

Postby FeyFre » Fri Jul 23, 2010 6:23 pm

It causes extra work during development, that is not helping phpBB's main goal of becoming a better forum software
So prosilver too. subsilver2 is not main reason of low phpBB development speed, and every member of PHPBB Team knows it perfectly.
naderman wrote:It causes extra work for MOD authors to support two very different templates - many don't even bother support both templates
Not an argument. The same can be said for prosilver! I do not support both templates, I support only one - subsilver2.
subsilver2 is easy for modification and maintain. It is easier to format page using tables than using divs. Tabled layout is more handy for dynamic manipulations.
So when I plan any phpbb modification, subsilver2 will be modified first, then whole modification will be debugged, and only then prosilver will be modified(if and only if prosilver wasn't deleted during board installation - in 90%% of cases in my life). I
User avatar
FeyFre
Registered User
 
Posts: 29
Joined: Wed Mar 17, 2010 9:49 pm

Previous Next

Return to [3.x] Rejected RFCs

Who is online

Users browsing this forum: No registered users and 0 guests