phpBB

Development Discussion Board

phpBB's testing ground of bleeding edge code
Advanced search

[RFC] Post log/record

Publish your own request for comments or patches for phpBB4. Discuss the contributions and proposals of others.
Forum rules
Information on how to create an RFC and a list of current RFCs can be found at http://wiki.phpbb.com/PhpBB4/RFC

Re: [RFC] Post log/record

Postby imkingdavid » Sat Apr 03, 2010 4:29 pm

naderman wrote:And systems like git store snapshots instead. The problem you get with storing differences is that you actually have to calculate a particular revision based on all the past revisions and the differences introduced in each one. Simply storing the entire post seems a lot more straight forward. As long as it is in a separate table it doesn't become a memory issue, and surely disk space is not the concern here?

I don't think disk space should be too big of a concern. Most posts on a forum are generally not edited. And those that are edited usually only get edited once or twice, except for like announcements or something.

And there could be an option when you edit, like "Save revision information for this revision" or something. And of course per post, per topic AND globally there should be an option to remove post revision information. And a global on/off switch. And maybe even a per topic and per post on/off switch as well. With all of this, admins could just turn it off or periodically prune the revisions table when it gets too big.

EDIT: And I forgot to talk about the actual topic of the quoted post, which was how to store the revision. In connection to what I said above, I likewise think that storing the whole post and doing a difference check after the fact is not going to take up too much space.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.
User avatar
imkingdavid
Development Team
Development Team
 
Posts: 906
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Post log/record

Postby EXreaction » Sat Apr 03, 2010 10:51 pm

Having the option when editing removes the whole reason behind having it. It is needed to keep track of things people say and have a record to keep moderators and users in check in case any problems come up.
My phpBB3 Mods: Advertisement Management | User Blog Mod | Anti-Spam ACP | Advanced Subscriptions | One Click Ban | From Author PM List | FAQ Manager | Forum Sponsors | Soft Delete | Auto Database Backup | Drag 'n Drop Forum List | HTML Ranks | Enable HTML
User avatar
EXreaction
Development Team
Development Team
 
Posts: 1274
Joined: Sat Sep 10, 2005 2:15 am

Previous

Return to [4.x] RFCs

Who is online

Users browsing this forum: No registered users and 2 guests