[Patch|Rejected] Dotted Topics showing unapproved posts

[Comkid]

Here is a link to the bug tracker: http://tracker.phpbb.com/browse/PHPBB3-9175

OPEN: includes/functions_display.php

FIND:

Code: Select all

global $user, $config; 

ADD AFTER:

Code: Select all

global $db; 

FIND:

Code: Select all

// Posted image?
        if (!empty($topic_row['topic_posted']) && $topic_row['topic_posted'])
        {
            $folder_img .= '_mine';
        } 

REPLACE WITH:

Code: Select all

$sql = 'SELECT *
                FROM ' . POSTS_TABLE . "
                WHERE post_approved = 0 AND poster_id = '" . $user->data['user_id'] . "' AND topic_id = '" . $topic_row['topic_id'] . "'";
        
        $result = $db->sql_query($sql);
        
        if ($result === false)
        {
            // Posted image?
            if (!empty($topic_row['topic_posted']) && $topic_row['topic_posted'])
            {
                $folder_img .= '_mine';
            }
        } 

[bantu]

Your suggestion is not going to work because the topic_status() function is called in a loop from viewforum.php

It would run n extra queries, where n is the number of topics being displayed.

[Comkid]

What do you mean? Do you mean it will do too many excess SQL queries or it won't work literally?

[bantu]

What do you mean? Do you mean it will do too many excess SQL queries or it won't work literally?

Yeah, too many SQL queries. It does work, but it's nothing that should go into phpBB product.

[nickvergessen]

This would also cause a topic were you have an approved and an unapproved post in, viewing as not replied.