Please discuss! If you want to contribut changes, you can post a patch (created with git format-patch) here. Alternatively you can fork the official repository on github yourself: http://github.com/phpbb/phpbb You can then add naderman/phpbb as an additional remote, pull the branch from it, make your changes, and let me know to pull them back into my repository.
Question: Why will phpBB 4 be using SPACES instead of TABS? Answer: So the code always looks the same regardless of what width you have your tabs set to. Having their tabs set to a width of 2 or 8 often caused people to indent incorrectly with tabs. Tabs also don't work very will in the middle of a line when trying to line up variable assignments for example.
Looks good to me as well aside from one minor thing (which Dog Cow already mentioned) -- the use of spaces instead of tabs. To be honest I don't understand the rationale here -- correct me if I'm wrong the purpose is so the code looks visually identical (or close) regardless of one's text editor settings. Even if that is the case, one will still likely need to configure their text editor to use spaces as tabs, which seems to defeat the purpose.
If nothing else, in most other projects I've seen, tabs seem to be the de facto standard. Changing it seems more like it would cause more annoyance than benefit.
Other than that, looks good -- reads well, clear, and above all, makes sense. Good work.
My phpbb.com account Note that any of my opinions expressed in RFC topics are my own and not necessarily representative of the opinion of the phpBB Team.