Suspecting beta release very very soon!

[Highway of Life]

Okay, so the limit is 31, not 20?
And sorry for the questions, but...
1) Can the limit be used in the DB instead of the files?
2) If it can't be used in the DB, can the limit be raised in the file?

[Lieutenant Clone]

Ok so if BBCode is the perfect solution, and and HTML can be made with BBCode... we are now limited by 31. So not all html tags can be made into BBCode, not to mention the different combos you could make with CSS and such, so really we are screwed .

[APTX]

No you cannot add 31 BBCodes... this number includes predinined BBCodes.

[NeoThermic]

Okay, so the limit is 31, not 20?
And sorry for the questions, but...
1) Can the limit be used in the DB instead of the files?
2) If it can't be used in the DB, can the limit be raised in the file?

The limit is indeed 31, but it is a limitation of the PHP language and the way BBCodes are used. We are looking into ways around the problem, so there won't be this low limit at release.

NeoThermic

[Lieutenant Clone]

Good to hear.

[th23]

May you give us an indication where to look to understand what is the limitation "31" based on?

[NeoThermic]

May you give us an indication where to look to understand what is the limitation "31" based on?

It comes down to PHP's datatypes and the bitshifting that phpBB does.

in bbcode.php:

Code: Select all

if ($this->bbcode_bitfield & (1 << $bbcode_id))

if $bbcode_id is 30, that line of code will return something ala:

Code: Select all

>php -n -r "var_dump(1 << 30);"
int(1073741824)

Where as, if its 31:

Code: Select all

>php -n -r "var_dump(1 << 31);"
int(-2147483648)

NeoThermic

[th23]

Thanks... even though i'm still not completely understanding what is going to happen in those lines... bus I'll have a look in the morning, when my brain starts working again

[Yoda_IRC]

Are you using PHP_INT_MAX to determine the limit?

I certianly hope you are because according the PHP manual the maximum size of an integer can be anything.

The size of an integer is platform-dependent

this means you have no way of knowing when writing the script what the maximum space is going to be.

[Lieutenant Clone]

Im sure this has been disscussed before, but could you please infrom me what the BBCode Id's accually do? As far as I can tell, they are just really annoying and take up extra parse time. I first met the buggers while trying to build a custom BBCode parser for a news script to be fed off the phpbb database (not fun BTW).

Ive been wondering this for a hella long time, would be nice to clear it up.