1000 to 1,000

[markus_petrux]

Here's a function I wrote some time ago for the purpose (a portal I was writting).

Code: Select all

/**
 * Wrapper for the PHP function number_format.
 *
 * Note thousands separator and decimal point are language dependent.
 *
 * @access public
 * @param float The number.
 * @param integer Number of decimals.
 * @return string The formatted number.
 */
function phpbb_number_format($number, $decimals = 0)
{
	global $lang;
	return number_format($number, $decimals, $lang['Number_decimal_point'], $lang['Number_thousands_sep']);
}

[winsrev]

Okay, do it in the language file then

[warmweer]

It could probably be defined in the language files, if its country dependency can be assumed from the language, otherwise it could be added to the user profile so they can choose it like they do with date format, time zone, etc.

Quoted for agreement. Language file would be the only sensible way.

Point taken and when it comes to numbers displayed in phpBB features I see no reason to differ in opinion. However, I kind of had the impression that the topic starter implied formatting all numbers in posts, and this is (IMHO) totally useless and could cause confusion.

[smithy_dll]

In windows it's set by locality (you can change to any character you want), as it should be in phpBB.

As for what IPB does, thats them, this is phpBB.

[uranusalien]

It could probably be defined in the language files, if its country dependency can be assumed from the language, otherwise it could be added to the user profile so they can choose it like they do with date format, time zone, etc.

Quoted for agreement. Language file would be the only sensible way.

Point taken and when it comes to numbers displayed in phpBB features I see no reason to differ in opinion. However, I kind of had the impression that the topic starter implied formatting all numbers in posts, and this is (IMHO) totally useless and could cause confusion.

No, I think he was referring to the formatting of statistics like number of topics in a forum.

I agree with using the language file - using a space would work, but there may be situations where a board is oriented heavily toward a specific locale. For example in the UK, commas are used.

[Limit-Studios]

thanxs for the code markus_petrux, i've added to my language files and have it working on my 2.0.19 forum.

[markus_petrux]

Sweet.

/me curious, what kind of numbers do you apply it?

[Limit-Studios]

the topics and post on the index and viewforum, and the members posts in viewtopic.

I hope thats what you meant. Thats all i have at the moment but i'm hopefully gonna have full formatting by the weekend on things such as total posts and total members but i have to add 1000+ test members to my test development server.

[markus_petrux]

Yes, that's what I meant. Thanks

[Limit-Studios]

the only thing i had to do was make a few changes using some of a MOD on another website. So it would parse properly and wouldn't stop after the ,

I now have it in my CVS of phpBB3 with a few changes here and there just for testing so i can use it on my phpBB3 forum when it's available.

Also i'm wondering is this likely to affect performance.