[GSOC 2018] Revamp PM system to chat based

Discuss general development subjects that are not specific to a particular version like the versioning control system we use or other infrastructure.
User avatar
akbarhashmi
Registered User
Posts: 13
Joined: Tue Feb 13, 2018 11:56 am

Re: [GSOC 2018] Revamp PM system to chat based

Post by akbarhashmi » Sat Mar 03, 2018 5:47 pm

That does sound more organised and was probably far-fetched as David pointed out.
But its probably not big enough to be a stand-alone project, which is why I'm assuming its not on the ideas list.

User avatar
hanakin
Infrastructure Team
Infrastructure Team
Posts: 845
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: [GSOC 2018] Revamp PM system to chat based

Post by hanakin » Wed Mar 07, 2018 1:42 am

that possibly and because I have not created a ticket for it so the whole team is not fully

User avatar
akbarhashmi
Registered User
Posts: 13
Joined: Tue Feb 13, 2018 11:56 am

Re: [GSOC 2018] Revamp PM system to chat based

Post by akbarhashmi » Wed Mar 14, 2018 8:05 am

I have a few questions about the core structure.

Core backend changes for the PM interface are made here
=> /phpBB/includes/ucp/ucp_pm.php

$mode = “view” : Currently, this is the default case when viewing Private Messages module.

If a folder is specified ($folder_specified) and $action = 'view_folder', messages in that folder will be displayed.

Code: Select all

=>	function view_folder ()
=>	/phpBB/includes/ucp/ucp_pm_viewfolder.php 
Or if $action == 'view_message' then we retrieve messages for specific conversation ($message_id, $messsage_row)

Code: Select all

=>	function view_message ()
=>	/phpBB/includes/ucp/ucp_pm_viewmessage.php
Now here's a mockup of the proposed system,

Image

Apart from the above mentioned, there are other functions such as get_pm_from(), get_user_information and new ones like quick_compose_pm(). (all of these have to be called concurrently of course)

Would it be best to move everything to a new file or call them from another function?

I also noticed $mode = "drafts" calls ucp_main() instead of its own ucp_pm_drafts() unlike the rest. So if I were to add something like "favourites" it would go there as well ?

request
Registered User
Posts: 6
Joined: Tue Jan 12, 2016 2:46 pm

Re: [GSOC 2018] Revamp PM system to chat based

Post by request » Fri Mar 16, 2018 2:37 am

Wow, looks great! Will it be fully ajax, or with some live notifications?

koraldon Online
Registered User
Posts: 25
Joined: Thu Mar 10, 2005 12:06 pm

Re: [GSOC 2018] Revamp PM system to chat based

Post by koraldon » Fri Mar 16, 2018 6:27 am

Agree :)

User avatar
akbarhashmi
Registered User
Posts: 13
Joined: Tue Feb 13, 2018 11:56 am

Re: [GSOC 2018] Revamp PM system to chat based

Post by akbarhashmi » Fri Mar 16, 2018 7:30 am

Im afraid not, this project is non-real time as mentioned

koraldon Online
Registered User
Posts: 25
Joined: Thu Mar 10, 2005 12:06 pm

Re: [GSOC 2018] Revamp PM system to chat based

Post by koraldon » Fri Mar 16, 2018 2:28 pm

This will be awesome regardless of Ajax ;)

Post Reply