PRs and WIP label

Discuss general development subjects that are not specific to a particular version like the versioning control system we use or other infrastructure.
Nicofuma
3.2 Release Manager
3.2 Release Manager
Posts: 299
Joined: Sun Apr 13, 2014 1:40 am
Location: Paris

Re: PRs and WIP label

Post by Nicofuma »

Nicofuma wrote:for that you need to post a special comment to your PR
Member of the phpBB Development-Team
No Support via PM

User avatar
hanakin
Front-End Dev Team Lead
Front-End Dev Team Lead
Posts: 906
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: PRs and WIP label

Post by hanakin »

Nicofuma wrote:
Nicofuma wrote:for that you need to post a special comment to your PR
so no thks
Donations welcome via Paypal Image

User avatar
hanakin
Front-End Dev Team Lead
Front-End Dev Team Lead
Posts: 906
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: PRs and WIP label

Post by hanakin »

these should probably at some point be added to the wiki with use cases

just so everyone is aware we have

!set WIP - mark your Pull Request as work in progress
!unset WIP - mark your Pull Request as ready for review
!set Styles - mark your Pull Request as related to the Styles for specific review
Donations welcome via Paypal Image

Nicofuma
3.2 Release Manager
3.2 Release Manager
Posts: 299
Joined: Sun Apr 13, 2014 1:40 am
Location: Paris

Re: PRs and WIP label

Post by Nicofuma »

feel free to edit the wiki =)
Member of the phpBB Development-Team
No Support via PM

cheshiretwin
Registered User
Posts: 1
Joined: Thu Oct 11, 2018 6:20 pm

Re: PRs and WIP label

Post by cheshiretwin »

Nicofuma wrote:
Fri Aug 08, 2014 12:55 pm
Now you are able to add or remove the WIP label to your own PRs, for that you need to post a special comment to your PR:

Code: Select all

!set WIP
to set the WIP label

Code: Select all

!unset WIP
to remove it

Example: https://github.com/phpbb/phpbb/pull/268 ... t-51595801
Thanks for the link.

User avatar
3Di
Registered User
Posts: 762
Joined: Tue Nov 01, 2005 9:50 pm
Location: Milano (I) Frankfurt (D)
Contact:

Re: PRs and WIP label

Post by 3Di »

Am I right it should be :construction: instead of WIP actually?
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
👨‍🏫 | Take a tour to | The Studio | 👨‍🏫

rubencm
Development Team
Development Team
Posts: 29
Joined: Sun Mar 12, 2017 8:30 pm
Location: h[b]ell[/b]o

Re: PRs and WIP label

Post by rubencm »

Code: Select all

!WIP :construction:

Post Reply