PRs and WIP label

Discuss general development subjects that are not specific to a particular version like the versioning control system we use or other infrastructure.
Nicofuma
3.2 Release Manager
3.2 Release Manager
Posts: 299
Joined: Sun Apr 13, 2014 1:40 am
Location: Paris

PRs and WIP label

Post by Nicofuma »

Now you are able to add or remove the WIP label to your own PRs, for that you need to post a special comment to your PR:

Code: Select all

!set WIP
to set the WIP label

Code: Select all

!unset WIP
to remove it

Example: https://github.com/phpbb/phpbb/pull/268 ... t-51595801
Member of the phpBB Development-Team
No Support via PM

User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: PRs and WIP label

Post by nickvergessen »

The development team will try to set your PRs to WIP if work needs to be done.
If you think you fixed all issues, just remove the WIP label again, so we can review it again.
Member of the Development-TeamNo Support via PM

User avatar
brunoais
Registered User
Posts: 964
Joined: Fri Dec 18, 2009 3:55 pm

Re: PRs and WIP label

Post by brunoais »

Ah! I didn't know such thing existed!

How did you do it? I want that for me as well!

Nicofuma
3.2 Release Manager
3.2 Release Manager
Posts: 299
Joined: Sun Apr 13, 2014 1:40 am
Location: Paris

Re: PRs and WIP label

Post by Nicofuma »

Member of the phpBB Development-Team
No Support via PM

User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 673
Joined: Mon Mar 08, 2010 9:18 am

Re: PRs and WIP label

Post by VSE »

Can we also have !set EVENT to add the Event label to event PRs?
Has an irascible disposition.

User avatar
MichaelC
Development Team
Development Team
Posts: 889
Joined: Thu Jan 28, 2010 6:29 pm

Re: PRs and WIP label

Post by MichaelC »

VSE wrote:Can we also have !set EVENT to add the Event label to event PRs?
Should work due to https://github.com/phpbb/dev-hooks/pull/2
Formerly known as Unknown Bliss
psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
No unsolicited PMs please except for quotes.

User avatar
hanakin
Front-End Dev Team Lead
Front-End Dev Team Lead
Posts: 907
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: PRs and WIP label

Post by hanakin »

Maybe instead of just turning the WIP on or off we could also have on for Ready for Review !set REVIEW
Donations welcome via Paypal Image

User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 673
Joined: Mon Mar 08, 2010 9:18 am

Re: PRs and WIP label

Post by VSE »

One side effect. When subscribed to a pr you may get an email when a set WIP comment is made.
Has an irascible disposition.

User avatar
MichaelC
Development Team
Development Team
Posts: 889
Joined: Thu Jan 28, 2010 6:29 pm

Re: PRs and WIP label

Post by MichaelC »

VSE wrote:One side effect. When subscribed to a pr you may get an email when a set WIP comment is made.
The other side to that is you also get an email when !unset WIP is run so you know the author has made changes/fixed something and it's ready for review.
Formerly known as Unknown Bliss
psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
No unsolicited PMs please except for quotes.

User avatar
hanakin
Front-End Dev Team Lead
Front-End Dev Team Lead
Posts: 907
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: PRs and WIP label

Post by hanakin »

Nicofuma wrote:

Code: Select all

!set WIP
Does this work from the original PR message? Say I create a new PR and add !set WIP or Style to the bottom of the PR message when I initially create it?
Donations welcome via Paypal Image

Post Reply