Adding template events, what do I fork?

Discuss general development subjects that are not specific to a particular version like the versioning control system we use or other infrastructure.
Post Reply
Danielx64
Registered User
Posts: 304
Joined: Mon Feb 08, 2010 3:42 am

Adding template events, what do I fork?

Post by Danielx64 »

Ok I read that all event request should be made against http://tracker.phpbb.com/browse/PHPBB3-9550 but what I'm not sure on is what do I fork out from github?

All I'm wanting is to add 2 template events now and maybe more later on.

User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: Adding template events, what do I fork?

Post by EXreaction »

When creating a new event, please add a new ticket for each event (if they are related, one new ticket and PR for the related ones is fine).

Simply fork https://github.com/phpbb/phpbb and make the changes in a new branch (typically the branch should be named ticket/ID for organizational purposes), then submit a pull request after pushing the changes to your fork on Github (there are better explanations in the wiki and we can assist you on #phpbb-dev)

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: Adding template events, what do I fork?

Post by imkingdavid »

To add to that, please be sure to follow our commit message guidelines when committing your changes. Also, be sure to base your branch on the "develop" branch. Oh, and don't forget to add the event to phpBB/docs/events.md in alphabetical order, following the existing formatting.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

Post Reply