Recently unknownbliss has been doing a lot of work on hooks for 3.1, in particular implementing a number of ledges. Right now these ledges are accumulating in my hooks+ledges diff along with the ones I add.
The ledges should be reviewed as all code that we commit gets reviewed. In case of ledges however I am not the best person to perform this review, as I do not write phpbb extensions/modifications. Ledge review deals primarily with the following three issues:
1. Ledge name
2. Exact location
3. Ledge parameters and their names
For example, we added a ledge to the copyright block in the footer. Should this ledge be before or after phpbb copyright?
The core does not really care for how these questions are answered. For extensions however, it would be unfortunate if we added a ledge that worked for one extension and almost worked but not quite for another extension. Then we'd either have to pile ledges one on top of another, which would be suboptimal, or we'd have to change existing ledges which might break extensions.
Therefore the idea is that the modification community would review the proposed ledges in a way similar to how the development team reviews core changes.
Unknownbliss mentioned that he might be interested in performing this review, which I would support. However it would be great if we had several people reviewing.
