Changes to file header in (almost) all phpBB files

Discuss general development subjects that are not specific to a particular version like the versioning control system we use or other infrastructure.
Post Reply
User avatar
MichaelC
Development Team
Development Team
Posts: 889
Joined: Thu Jan 28, 2010 6:29 pm

Changes to file header in (almost) all phpBB files

Post by MichaelC »

This originally started as a ticket for the license URL to be changed from the old URL pointing to a gateway page for the GPL v2 and v3 to the v2 page. Then the Version $Id$ was to also be removed and there were also some whitespace changes.
However, it also requires a change to the phpBB/develop/ files, the test files and the coding guidelines as well as the core files.

The coding guidelines need an update on Line 216 and 2414 but any new files that are added to olympus need to have the new header block as the patch for headers in 3.1 is only being applied once in 3.1

So Oleg's propsal was:
  • Tests and phpBB/develop, as neither are distributed, should have the changes applied to their headers in olympus.
  • The Coding Guidelines would have the changes applied in the two locations in olympus for new files added, however, on a not development related note, this would require any newly submitted modifications to have this new header section (unless an exception is added to the policies) as they have to follow coding guidelines, but not sure how much of an issue this could be seen as.
  • The other main distributed core files would be changed in 3.1

IRC Conversation: https://gist.github.com/d5636019613ccc9c8888
Ticket: http://tracker.phpbb.com/browse/PHPBB3-9916
Original PR for 3.1: https://github.com/phpbb/phpbb3/pull/509
Formerly known as Unknown Bliss
psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
No unsolicited PMs please except for quotes.

User avatar
bantu
3.0 Release Manager
3.0 Release Manager
Posts: 557
Joined: Thu Sep 07, 2006 11:22 am
Location: Karlsruhe, Germany
Contact:

Re: Changes to file header in (almost) all phpBB files

Post by bantu »

I am in favour of doing this.

You can safely alter anything outside of the phpBB folder and inside of phpBB/docs and phpBB/develop.

User avatar
bantu
3.0 Release Manager
3.0 Release Manager
Posts: 557
Joined: Thu Sep 07, 2006 11:22 am
Location: Karlsruhe, Germany
Contact:

Re: Changes to file header in (almost) all phpBB files

Post by bantu »

These changes have been made.

develop-olympus: https://github.com/phpbb/phpbb3/pull/522
develop: https://github.com/phpbb/phpbb3/pull/509

Post Reply