Github contribution guidelines not always working

Discuss general development subjects that are not specific to a particular version like the versioning control system we use or other infrastructure.
Post Reply
Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Github contribution guidelines not always working

Post by Oleg »

Per the readme file, the following is needed to contribute:

1. Create an account on phpBB.com
2. Create a ticket (unless there already is one)
3. Read our Git Contribution Guidelines; if you're new to git, also read the introduction guide
4. Send us a pull request

However, tracker does not allow login by people in newly registered users group. Thus in actuality between #1 and #2 there is another step which is to post on the phpbb.com forums and wait for your post to be approved and the account moved into registered users group.

I know personally of at least one user who was puzzled at their inability to login to tracker. I'm guessing the reason it was done this way was to prevent spam, but could we perhaps allow newly registered users access to the tracker for a trial period?
User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1864
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: Github contribution guidelines not always working

Post by DavidIQ »

There would still be a delay between when the user registers on phpbb.com and their account gets propagated to JIRA. Actually changing how the auth system currently works in JIRA is also a major pain...but it can be done I suppose.
Image
Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: Github contribution guidelines not always working

Post by Oleg »

Even so waiting is much less annoying than having to post on .com.
User avatar
naderman
Consultant
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Berlin, Germany
Contact:

Re: Github contribution guidelines not always working

Post by naderman »

Indeed, waiting might be acceptable but posting certainly isn't.

Authentication on the tracker works immediately btw, no delay there since it directly access the phpbb.com db via the auth api on github.
Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: Github contribution guidelines not always working

Post by Oleg »

If we can't or won't allow the newly registered user group access to tracker this at least needs to be mentioned in the contribution guidelines. This issue could easily be very annoying to users.
User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1864
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: Github contribution guidelines not always working

Post by DavidIQ »

naderman wrote:Authentication on the tracker works immediately btw, no delay there since it directly access the phpbb.com db via the auth api on github.
We're not really talking about authentication. Yes authentication actually works fairly quickly but your account is not immediately pulled into the tracker when registering. Example
Image
Post Reply