Does refactoring count as a feature?

Discuss general development subjects that are not specific to a particular version like the versioning control system we use or other infrastructure.
Post Reply
Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Does refactoring count as a feature?

Post by Oleg »

I want to ask for clarification of the "feature freeze" outlined in viewtopic.php?f=84&t=33015.

Let's say I change organization of some code by creating functions and moving code from global scope into functions, or alternatively break up functions into smaller functions. In this process I only change the code to the extent necessary to move it.

1. Do such modifications count as features for the purposes of feature freeze?

2. Do they require an RFC?
User avatar
rxu
Registered User
Posts: 151
Joined: Tue Apr 04, 2006 4:28 pm
Contact:

Re: Does refactoring count as a feature?

Post by rxu »

In my personal opinion code reorganization has nothing to do with features, and thus it shouldn't require RFC.
Image
User avatar
naderman
Consultant
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Berlin, Germany
Contact:

Re: Does refactoring count as a feature?

Post by naderman »

I agree that it is not a feature, however our goal for Ascraeus was not to refactor everything just for the sake of cleaning it up (would be too much work, that's what phpBB4 is aimed at ;-)). But if some feature/bug requires code changes anyway, you may as well refactor related code.
Post Reply