phpBB

Development Discussion Board

phpBB's testing ground of bleeding edge code
Advanced search

Does refactoring count as a feature?

Discuss general development subjects that are not specific to a particular version like the versioning control system we use or other infrastructure.

Does refactoring count as a feature?

Postby Oleg » Sat Jan 08, 2011 2:31 am

I want to ask for clarification of the "feature freeze" outlined in viewtopic.php?f=84&t=33015.

Let's say I change organization of some code by creating functions and moving code from global scope into functions, or alternatively break up functions into smaller functions. In this process I only change the code to the extent necessary to move it.

1. Do such modifications count as features for the purposes of feature freeze?

2. Do they require an RFC?
Oleg
3.1 Release Manager
3.1 Release Manager
 
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am

Re: Does refactoring count as a feature?

Postby rxu » Sat Jan 08, 2011 2:33 pm

In my personal opinion code reorganization has nothing to do with features, and thus it shouldn't require RFC.
Image
rxu
Registered User
 
Posts: 87
Joined: Tue Apr 04, 2006 4:28 pm

Re: Does refactoring count as a feature?

Postby naderman » Sat Jan 08, 2011 6:14 pm

I agree that it is not a feature, however our goal for Ascraeus was not to refactor everything just for the sake of cleaning it up (would be too much work, that's what phpBB4 is aimed at ;-)). But if some feature/bug requires code changes anyway, you may as well refactor related code.
www.naderman.de
Move your forum to Forumatic - we'll take care of maintenance & spam
User avatar
naderman
Development Team Leader
Development Team Leader
 
Posts: 1649
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany


Return to General Development Discussion

Who is online

Users browsing this forum: No registered users and 6 guests

cron