Git hooks

Discuss general development subjects that are not specific to a particular version like the versioning control system we use or other infrastructure.
ToonArmy
Registered User
Posts: 335
Joined: Fri Mar 26, 2004 7:31 pm
Location: Bristol, UK
Contact:

Re: Git hooks

Post by ToonArmy » Sat Aug 07, 2010 1:43 am

Chris SmithBlogXMOOhlohArea51WikiNo support via PM/IM
Image

User avatar
bantu
3.0 Release Manager
3.0 Release Manager
Posts: 557
Joined: Thu Sep 07, 2006 11:22 am
Location: Karlsruhe, Germany
Contact:

Re: Git hooks

Post by bantu » Tue Aug 10, 2010 1:55 pm

Merged into develop-olympus.

Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: Git hooks

Post by Oleg » Thu Aug 19, 2010 2:57 am

Useful error message in pre-commit hook when php is not installed: http://github.com/p/phpbb3/compare/git-tools

User avatar
bantu
3.0 Release Manager
3.0 Release Manager
Posts: 557
Joined: Thu Sep 07, 2006 11:22 am
Location: Karlsruhe, Germany
Contact:

Re: Git hooks

Post by bantu » Thu Aug 19, 2010 3:58 pm

nn- wrote:Useful error message in pre-commit hook when php is not installed: http://github.com/p/phpbb3/compare/git-tools
Good idea. Created ticket http://tracker.phpbb.com/browse/PHPBB3-9777

ToonArmy
Registered User
Posts: 335
Joined: Fri Mar 26, 2004 7:31 pm
Location: Bristol, UK
Contact:

Re: Git hooks

Post by ToonArmy » Fri Aug 20, 2010 2:47 pm

bantu wrote:
nn- wrote:Useful error message in pre-commit hook when php is not installed: http://github.com/p/phpbb3/compare/git-tools
Good idea. Created ticket http://tracker.phpbb.com/browse/PHPBB3-9777
FYI It's been merged and just needs verifying.
Chris SmithBlogXMOOhlohArea51WikiNo support via PM/IM
Image

User avatar
bantu
3.0 Release Manager
3.0 Release Manager
Posts: 557
Joined: Thu Sep 07, 2006 11:22 am
Location: Karlsruhe, Germany
Contact:

Re: Git hooks

Post by bantu » Mon Aug 23, 2010 3:07 am

When using "git revert" the prepared revert commit message should contain the ticket ids (e.g. PHPBB3-1234) of the commits that are being reverted. Is that possible?

igorw
Registered User
Posts: 500
Joined: Thu Jan 04, 2007 11:47 pm

Re: Git hooks

Post by igorw » Wed Aug 25, 2010 11:46 pm

I'm having some issues. The `wc` that ships with OS X does not support --max-line-length or --lines.

Maybe add a check for OS X in which case to disable that feature? Not sure what's the best way to check that though.

Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: Git hooks

Post by Oleg » Thu Aug 26, 2010 8:44 pm

wc -l is specified in posix (http://www.opengroup.org/onlinepubs/000 ... es/wc.html), use it instead of --lines.

Max line length sounds like it could be replaced with cut.

ToonArmy
Registered User
Posts: 335
Joined: Fri Mar 26, 2004 7:31 pm
Location: Bristol, UK
Contact:

Re: Git hooks

Post by ToonArmy » Sat Aug 28, 2010 4:17 pm

nn- wrote:wc -l is specified in posix (http://www.opengroup.org/onlinepubs/000 ... es/wc.html), use it instead of --lines.

Max line length sounds like it could be replaced with cut.
How would one go about that with cut?
Chris SmithBlogXMOOhlohArea51WikiNo support via PM/IM
Image

igorw
Registered User
Posts: 500
Joined: Thu Jan 04, 2007 11:47 pm

Re: Git hooks

Post by igorw » Tue Sep 07, 2010 9:04 pm

Can we have that section commented out until a cross-platform solution is found? I'd really like to re-enable my git plugins. :)

Post Reply