[RFC] Define max-width for prosilver

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
Locked
User avatar
callumacrae
Former Team Member
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: Define max-width for prosilver

Post by callumacrae »

That's 6 pixels different ಠ_ಠ
Made by developers, for developers!
My blog

User avatar
PayBas
Registered User
Posts: 305
Joined: Tue Jul 29, 2008 6:08 pm
Contact:

Re: Define max-width for prosilver

Post by PayBas »

callumacrae wrote:That's 6 pixels different ಠ_ಠ
It was a typo :lol:, don't play coy.

User avatar
hanakin
Front-End Dev Team Lead
Front-End Dev Team Lead
Posts: 912
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: Define max-width for prosilver

Post by hanakin »

6 very important pixels :twisted:
Donations welcome via Paypal Image

User avatar
PayBas
Registered User
Posts: 305
Joined: Tue Jul 29, 2008 6:08 pm
Contact:

Re: Define max-width for prosilver

Post by PayBas »

Since we will introduce a max-width, that means that there will be quite a lot of #FFF on both sides, especially on high-res devices. It's incredibly bright.

We could do something similar to what phpbb.com does. White wrap, darker bg.
fx.png
(103.3 KiB) Downloaded 577 times

User avatar
Sumanai
Registered User
Posts: 95
Joined: Sat Aug 31, 2013 11:12 am

Re: Define max-width for prosilver

Post by Sumanai »

PayBas, I agree, but I believe that the top margin with gray color is not needed.
Sorry for my English.

User avatar
Mess
Registered User
Posts: 199
Joined: Wed Jun 13, 2012 10:14 am

Re: Define max-width for prosilver

Post by Mess »

PayBas wrote:Since we will introduce a max-width, that means that there will be quite a lot of #FFF on both sides, especially on high-res devices. It's incredibly bright.

We could do something similar to what phpbb.com does. White wrap, darker bg.
fx.png
+1

User avatar
PayBas
Registered User
Posts: 305
Joined: Tue Jul 29, 2008 6:08 pm
Contact:

Re: Define max-width for prosilver

Post by PayBas »

Alternative with 100% height, no top/bottom padding and no border-radius.
2.png
(61.23 KiB) Downloaded 539 times

User avatar
callumacrae
Former Team Member
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: Define max-width for prosilver

Post by callumacrae »

Too drastic?

Image
Made by developers, for developers!
My blog

User avatar
Sumanai
Registered User
Posts: 95
Joined: Sat Aug 31, 2013 11:12 am

Re: Define max-width for prosilver

Post by Sumanai »

@PayBas, I would have done without the inner shadow # wrap * , but still looks good.

* Outdoor shadow visually lifts the central part of the forum, inner shadow destroys the illusion, so it is useless.
Last edited by Sumanai on Wed Jun 11, 2014 8:26 am, edited 1 time in total.
Sorry for my English.

User avatar
Sumanai
Registered User
Posts: 95
Joined: Sat Aug 31, 2013 11:12 am

Re: Define max-width for prosilver

Post by Sumanai »

callumacrae wrote:Too drastic?
Badly, to be honest. Version of PayBas I like the most.
Sorry for my English.

Locked