[RFC] Define max-width for prosilver

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
Locked
User avatar
keith10456
Registered User
Posts: 523
Joined: Sat Apr 22, 2006 10:29 pm
Contact:

Re: Define max-width for prosilver

Post by keith10456 » Tue Jul 08, 2014 1:58 pm

Looks great in my opinion. We still have a ways to go but it's a welcoming change for the better.

User avatar
mrgtb
Registered User
Posts: 217
Joined: Wed Nov 28, 2007 10:09 pm

Re: Define max-width for prosilver

Post by mrgtb » Tue Jul 08, 2014 5:07 pm

Would be nice to see the search box in header right-side get updated to look a little nicer style wise. get rid of that grey old looking (windows 2000 pro) era button and maybe have a nicer styled search box, then again that old styled button is used in many areas.

We have this now.
1.PNG
1.PNG (3.54 KiB) Viewed 7260 times
When something like this (just an example) could look much better.
2.png
2.png (3.87 KiB) Viewed 7260 times
There are many other things I'd like to see get changed, but won't waffle on about it. Just hope some more nice changes are coming before gold release to ProSilver theme.

User avatar
keith10456
Registered User
Posts: 523
Joined: Sat Apr 22, 2006 10:29 pm
Contact:

Re: Define max-width for prosilver

Post by keith10456 » Tue Jul 08, 2014 5:29 pm

FYI... Changing the search was discussed in this topic (Though it probably needs its own topic by now).

User avatar
hanakin Online
Infrastructure Team
Infrastructure Team
Posts: 790
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: Define max-width for prosilver

Post by hanakin » Tue Jul 08, 2014 5:52 pm

FYI: https://github.com/phpbb/phpbb/pull/2504

@mrgtb check https://github.com/phpbb/phpbb/pulls before making suggestions as it might already be in the works and by looking at the PR you can +1 it their

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1731
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: Define max-width for prosilver

Post by DavidIQ » Tue Jul 08, 2014 11:38 pm

I think it's time to lock this topic as it has apparently become everyone's go to topic for discussing anything style related. The max-width change has been merged and there really isn't much else to say about that specific change.

Devs: feel free to unlock if you think there is any further discussion to be had here.
Image

Locked