[RFC] Define max-width for prosilver

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
Locked
User avatar
hanakin
Front-End Dev Team Lead
Front-End Dev Team Lead
Posts: 906
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: Define max-width for prosilver

Post by hanakin »

meh whatev I think the BG color is fine, 1 issue I have is to please stop mixing sizes for spacing should stay consistent IE: 12px margin on wrap with 15px padding?
Donations welcome via Paypal Image

User avatar
Louis7777
Registered User
Posts: 385
Joined: Fri Apr 04, 2014 12:32 am

Re: Define max-width for prosilver

Post by Louis7777 »

VSE wrote:I want to propose f2f2f2 as the BG color instead of the blue-white that was just merged...
+1

Let's use #f2f2f2 or something even darker like the BG color of phpbb.com

User avatar
callumacrae
Former Team Member
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: Define max-width for prosilver

Post by callumacrae »

Can we get this live on A51 ASAP?
Made by developers, for developers!
My blog

User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: Define max-width for prosilver

Post by nickvergessen »

@callumacrae: its being worked on
Member of the Development-TeamNo Support via PM

User avatar
Meis2M
Registered User
Posts: 433
Joined: Fri Apr 23, 2010 10:18 am
Contact:

Re: Define max-width for prosilver

Post by Meis2M »

hoooooooom.
its nice.

User avatar
Ger
Registered User
Posts: 293
Joined: Mon Jul 26, 2010 1:55 pm
Location: 192.168.1.100
Contact:

Re: Define max-width for prosilver

Post by Ger »

Thumbs up!
Above message may contain errors in grammar, spelling or wrongly chosen words. This is because I'm not a native speaker. My apologies in advance.

User avatar
Louis7777
Registered User
Posts: 385
Joined: Fri Apr 04, 2014 12:32 am

Re: Define max-width for prosilver

Post by Louis7777 »

So, can we have the bg color changed to #f2f2f2 like VSE suggested?

User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 670
Joined: Mon Mar 08, 2010 9:18 am

Re: Define max-width for prosilver

Post by VSE »

The bottom of the page seems a little odd.

The corners are rounded, but the bottom has no padding/margin. So that would mean the corners should not be rounded, but I assume they are for pages that do not extend to the bottom of the browser window. So, there should probably be a little margin/padding at the bottom of the page to give those rounded corners purpose.
Has an irascible disposition.

User avatar
hanakin
Front-End Dev Team Lead
Front-End Dev Team Lead
Posts: 906
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: Define max-width for prosilver

Post by hanakin »

VSE wrote:The bottom of the page seems a little odd.

The corners are rounded, but the bottom has no padding/margin. So that would mean the corners should not be rounded, but I assume they are for pages that do not extend to the bottom of the browser window. So, there should probably be a little margin/padding at the bottom of the page to give those rounded corners purpose.
hanakin wrote:meh whatev I think the BG color is fine, 1 issue I have is to please stop mixing sizes for spacing should stay consistent IE: 12px margin on wrap with 15px padding?
what I was saying the spacing needs worked
Donations welcome via Paypal Image

User avatar
PayBas
Registered User
Posts: 305
Joined: Tue Jul 29, 2008 6:08 pm
Contact:

Re: Define max-width for prosilver

Post by PayBas »

I agree that maybe 12/15px is odd (although hardly a big problem), but which browser are you using?

The rounded corners at the bottom do not reach the bottom of my screen. There's a margin there.

Locked