[RFC] Move navbar(s) to new template file (navbar_header.html)

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
Post Reply
User avatar
PayBas
Registered User
Posts: 305
Joined: Tue Jul 29, 2008 6:08 pm
Contact:

[RFC] Move navbar(s) to new template file (navbar_header.html)

Post by PayBas » Wed Apr 09, 2014 12:56 pm

Now that the template engine is much more powerful, I think many style developers will start to use template inheritance more and more. The overall_header.html is of course one of the most important.

Would it be a good idea to move the <div class="navbar"> section to a new template file navbar_header.html?

It's gotten pretty big.

Additionally, we could move the footer navbar as well (to navbar_footer), for symmetry ;).
Last edited by PayBas on Wed Apr 09, 2014 3:54 pm, edited 2 times in total.


User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Move navbar(s) to new template file (navbar_header.html)

Post by imkingdavid » Sun Apr 13, 2014 3:16 am

This was merged, so I'm moving it to the Merged RFCs forum.

EDIT: I moved it to 3.1 Merged RFCs but it was merged into 3.2 so I'm moving into the 3.2 Merged RFCs forum.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
prototech
Former Team Member
Posts: 53
Joined: Mon Mar 12, 2007 12:25 am

Re: [RFC] Move navbar(s) to new template file (navbar_header.html)

Post by prototech » Sun Apr 13, 2014 8:06 am

It was merged into 3.1. The PR was simply submitted against the wrong branch. :)

User avatar
keith10456
Registered User
Posts: 523
Joined: Sat Apr 22, 2006 10:29 pm
Contact:

Re: [RFC] Move navbar(s) to new template file (navbar_header.html)

Post by keith10456 » Sun Apr 13, 2014 11:45 pm

prototech wrote:It was merged into 3.1...
Great news :D

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Move navbar(s) to new template file (navbar_header.html)

Post by imkingdavid » Mon Apr 14, 2014 5:45 am

prototech wrote:It was merged into 3.1. The PR was simply submitted against the wrong branch. :)
Ahh, good catch. Thanks for the correction :)
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

Post Reply