[RFC] Don't Crop Image Attachments at 350px

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
Post Reply
User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 670
Joined: Mon Mar 08, 2010 9:18 am

[RFC] Don't Crop Image Attachments at 350px

Post by VSE » Sun Apr 06, 2014 4:04 pm

Image attachments that are placed inline in posts (not thumb-nailed) are presented inside of an invisible DIV element contained to a maximum height of 350 pixels.

This means that if your attachment settings for images allow images to display that are bigger than this restriction, the image will appear cropped, and the user must scroll within the DIV element to see all of the image.

I do not see why the DIV containing the inline image attachments needs to be restricted to a max height of 350px. It should allow the entire posted image attachment to show, same as the [ img ] tag does. I would also argue this for the non-inline attachments as well (which are presented inside of a visible DIV box)

I propose removing this limitation. Basically just removing the max-height: 350px; overflow: auto; rules from the "attach-image" class resolves this issue.

It should be noted that subsilver2 does not have this limit, and shows the images in all their glory.
Has an irascible disposition.

User avatar
PayBas
Registered User
Posts: 305
Joined: Tue Jul 29, 2008 6:08 pm
Contact:

Re: [RFC] Don't Crop Image Attachments at 350px

Post by PayBas » Sun Apr 06, 2014 4:32 pm

Agreed. And perhaps it makes things easier for your lightbox script too.

User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 670
Joined: Mon Mar 08, 2010 9:18 am

Re: [RFC] Don't Crop Image Attachments at 350px

Post by VSE » Sun Apr 06, 2014 4:37 pm

Has an irascible disposition.

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Don't Crop Image Attachments at 350px

Post by imkingdavid » Sun Apr 13, 2014 3:19 am

This was merged into 3.1, so I'm moving this to the 3.1 Merged RFCs forum.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.


Post Reply