[RFC] Update jQuery included in 3.1 to 1.11.0

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
User avatar
Sumanai
Registered User
Posts: 95
Joined: Sat Aug 31, 2013 11:12 am

Re: [RFC] Update jQuery included in 3.1 to 1.11.0

Post by Sumanai » Fri Apr 04, 2014 6:43 pm

What's the problem? Use the code

Code: Select all

<!--[if lt IE 9]>
<script src="./forum/assets/js/jquery-1.11.x.js"></script>
<![endif]-->
<!--[if gte IE 9]><!-->
<script src="./forum/assets/js/jquery-2.0.x.js"></script>
<!--<![endif]-->
2.0.x to connect to modern browsers, and in 1.9.x obsolete.
Sorry for my English.

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1731
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [RFC] Update jQuery included in 3.1 to 1.11.0

Post by DavidIQ » Sat Apr 05, 2014 2:18 am

Because we don't want to be including two versions of the same library especially if they're both functionally the same? If you read through the rest of this topic you'll see that there is no benefit for end users, extension writers, or administrators in going with version 2.0 and breaking compatibility with older browsers. Nothing is lost by going with 1.11 and nothing would be gained in going with 2.0.
Image

User avatar
Sumanai
Registered User
Posts: 95
Joined: Sat Aug 31, 2013 11:12 am

Re: [RFC] Update jQuery included in 3.1 to 1.11.0

Post by Sumanai » Sat Apr 05, 2014 2:25 pm

Will benefit in speed. Since version 2.0 does not pull the cargo compatibility with older browsers, it is faster and weighs less.
Sorry for my English.

User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: [RFC] Update jQuery included in 3.1 to 1.11.0

Post by nickvergessen » Sat Apr 05, 2014 3:27 pm

You will notice the 0.01 seconds in loading :ugeek:
Member of the Development-TeamNo Support via PM

User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 670
Joined: Mon Mar 08, 2010 9:18 am

Re: [RFC] Update jQuery included in 3.1 to 1.11.0

Post by VSE » Sat Apr 05, 2014 3:34 pm

Sumanai wrote:Will benefit in speed. Since version 2.0 does not pull the cargo compatibility with older browsers, it is faster and weighs less.
No. jQuery 2 is 12.7 kb smaller. Hardly a savings worth anything, especially considering after it's first loaded, it's cached.

The loss of functionality to all users on IE8 and below far outweighs the above.

jQuery 2.0 is intended for modern web-apps targeted only at modern browsers. phpBB is no such project. phpBB still needs to cast as wide a net of compatibility as possible.
Has an irascible disposition.

User avatar
Sumanai
Registered User
Posts: 95
Joined: Sat Aug 31, 2013 11:12 am

Re: [RFC] Update jQuery included in 3.1 to 1.11.0

Post by Sumanai » Sat Apr 05, 2014 4:49 pm

nickvergessen wrote:You will notice the 0.01 seconds in loading :ugeek:
Overhead to perform redundant code compatibility with older IE will accumulate.
VSE+ wrote:The loss of functionality to all users on IE8 and below far outweighs the above.
Look at the code that I posted above. It allows you to load jQuery in modern browsers, and jQuery 1.x in IE 8 and older.
VSE+ wrote:jQuery 2.0 is intended for modern web-apps targeted only at modern browsers.
jQuery 2.0-just a continuation of jQuery 1.x, the same library. Its concept has not changed.
Sorry for my English.

User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 670
Joined: Mon Mar 08, 2010 9:18 am

Re: [RFC] Update jQuery included in 3.1 to 1.11.0

Post by VSE » Sat Apr 05, 2014 6:21 pm

Sumanai wrote:Look at the code that I posted above.
They're not putting in nasty IE-only conditional comments (hacks) to load one version for old IE and another for all else. This is a moot point.
Has an irascible disposition.

User avatar
Sumanai
Registered User
Posts: 95
Joined: Sat Aug 31, 2013 11:12 am

Re: [RFC] Update jQuery included in 3.1 to 1.11.0

Post by Sumanai » Sat Apr 05, 2014 6:37 pm

This code works stably, it is valid markup.
Sorry for my English.

User avatar
PayBas
Registered User
Posts: 305
Joined: Tue Jul 29, 2008 6:08 pm
Contact:

Re: [RFC] Update jQuery included in 3.1 to 1.11.0

Post by PayBas » Sat Apr 05, 2014 6:54 pm

Sumanai wrote:This code works stably, it is valid markup.
I think your pleading is to no avail. I don't see it happening for 3.1 ;).

But nobody is stopping you from implementing it on your board :)

User avatar
M.Gaetan89
Registered User
Posts: 64
Joined: Tue Jan 28, 2014 7:17 pm
Location: Divonne-les-Bains, France
Contact:

Re: [RFC] Update jQuery included in 3.1 to 1.11.0

Post by M.Gaetan89 » Sat May 03, 2014 1:57 pm

What do you think about using the newly released jQuery 1.11.1?

Post Reply