Rename "purge" to "uninstall", differentiate between "install" and "enable"

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: Rename "purge" to "uninstall", differentiate between "install" and "enable"

Post by EXreaction » Mon Nov 11, 2013 2:50 am

I am not sure how that would work correctly with both having differing left/right id trees

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: Rename "purge" to "uninstall", differentiate between "install" and "enable"

Post by imkingdavid » Mon Nov 11, 2013 3:36 pm

Could we add a 0-default "extension_id" field to the modules table that could be used to associate extensions with their added modules? It would be assigned in the background when the module.add migration is run, and then it would be a simple action during the disable process to grab all of the extension's modules by that ID and disable those modules. Of course this wouldn't work retroactively, but that shouldn't matter since we're still in alpha.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: Rename "purge" to "uninstall", differentiate between "install" and "enable"

Post by nickvergessen » Mon Nov 11, 2013 5:30 pm

Just use the disable option we have on modules table?

We just need to store which modules were added by which extension (an extension might add a core module again to it's own category) and which have been disabled by disabling the extension and should be re-enabled when the extension is re-enabled.
Member of the Development-TeamNo Support via PM

User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: Rename "purge" to "uninstall", differentiate between "install" and "enable"

Post by EXreaction » Mon Nov 11, 2013 5:52 pm

The migrator is completely independent from extensions. It does not know or care whether or not the modules being added are from the core or an extension. I'm not sure this is something we should change either.

We could easily add a new permission type to modules, similar to config/acl checks we have now. Authors however would be required to add this to their module auth.

Post Reply