[RFC] Add ACP link to the top of the index

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
User avatar
Kamahl19
Registered User
Posts: 161
Joined: Thu Dec 27, 2007 10:31 am

Re: [RFC] Add ACP link to the top of the index

Post by Kamahl19 » Fri Oct 25, 2013 2:13 pm

You dont go to ACP very often so I think it does not have to be on the quickest place.

User avatar
bonelifer
Community Team
Community Team
Posts: 107
Joined: Mon Jan 31, 2005 10:41 am

Re: [RFC] Add ACP link to the top of the index

Post by bonelifer » Fri Oct 25, 2013 9:22 pm

I use the Administrate User function to ban people, clear their profile info if they are spammers. So yes I do use it often.

User avatar
Master_Cylinder
Registered User
Posts: 361
Joined: Wed Jul 31, 2013 9:54 pm

Re: [RFC] Add ACP link to the top of the index

Post by Master_Cylinder » Fri Oct 25, 2013 10:59 pm

To check logs too I use it every day...
These kids today...
Buy them books, send them to school and what do they do?

They eat the paste. :lol:

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Add ACP link to the top of the index

Post by imkingdavid » Sat Oct 26, 2013 12:41 am

I agree that adding an extra click to get the ACP is probably not the best idea, so leaving the MCP link where it is an adding an ACP link next to it (while also leaving the current link at the footer) would probably be the best idea. I'll get a PR up.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Add ACP link to the top of the index

Post by imkingdavid » Sat Oct 26, 2013 1:35 am

PR: https://github.com/phpbb/phpbb/pull/1826

EDIT: Screenshots:
Prosilver:
Image
Subsilver:
Image
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 670
Joined: Mon Mar 08, 2010 9:18 am

Re: [RFC] Add ACP link to the top of the index

Post by VSE » Sat Oct 26, 2013 1:50 am

imkingdavid wrote:PR: https://github.com/phpbb/phpbb/pull/1826

EDIT: Screenshots:
Prosilver:
Image
Subsilver:
Image
Of course my gut reaction is to say NOOOO!!!!!!! Cluttered... Different... We fear change... Then again, it is always a pain to have to scroll all the way to the bottom of the page to get to the Admin Panel link, so.... perhaps this is a good idea. 8-)
Has an irascible disposition.

User avatar
Pony99CA
Registered User
Posts: 986
Joined: Sun Feb 08, 2009 2:35 am
Location: Hollister, CA
Contact:

Re: [RFC] Add ACP link to the top of the index

Post by Pony99CA » Sat Oct 26, 2013 3:55 am

I've always thought that they should be together. I presume that the bar will disappear if the user only has Admin or Moderator permissions but not both.

Steve
Silicon Valley Pocket PC (http://www.svpocketpc.com)
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Add ACP link to the top of the index

Post by imkingdavid » Sat Oct 26, 2013 4:26 am

Pony99CA wrote:I've always thought that they should be together. I presume that the bar will disappear if the user only has Admin or Moderator permissions but not both.

Steve
Yes, the logic is basically:

Code: Select all

if admin then:
    print "L_ACP"
    if mod:
        print " | "
endif
if mod then:
    print "L_MCP"
endif
The pipe is only shown if both the ACP and MCP links are present.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
wintstar
Registered User
Posts: 108
Joined: Sun Dec 02, 2012 1:38 pm
Location: Lanngöns/Hessen Germany
Contact:

Re: [RFC] Add ACP link to the top of the index

Post by wintstar » Sat Oct 26, 2013 6:28 am

In the patch, I do not see that the ACP link was removed in overall_footer.html.
Greeting Stephan :-)

Quote: "To achieve the possible, the impossible has to be tried again and again" (Hermann Hesse (1877-1962)).
A look into the future phpBB 3.1.0 - Board, current Builds
A look into the future phpBB 3.1.0 - Board-Plus, Extensions in the test

User avatar
Un1matr1x
Registered User
Posts: 48
Joined: Mon Sep 07, 2009 10:18 pm

Re: [RFC] Add ACP link to the top of the index

Post by Un1matr1x » Sat Oct 26, 2013 2:39 pm

wintstar wrote:
In the patch, I do not see that the ACP link was removed in overall_footer.html.
which is intended
imkingdavid wrote:I'm fine with this, as long as we keep the current link in the bottom as well.[...]
imkingdavid wrote:[...](while also leaving the current link at the footer)[...]

Post Reply