Link topic to first unread post

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
Post Reply
User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1731
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: Link topic to first unread post

Post by DavidIQ » Tue Apr 01, 2014 1:41 am

I think you're confused. Visiting this:
https://area51.phpbb.com/phpBB/viewtopi ... ead#unread
Which was the link that the topic title was being generated as before the last change, will take you to the last page of the topic after you've read all posts in the topic. It does not take you to the first page.

This behavior has not changed, which is fine. The point is that it was also convenient to click on the title to get to the last page and would have been fine to move this off to the topic icon but this now disappears through removal of the ability to click on the topic icon after you've read all posts in the topic.
Image

User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 670
Joined: Mon Mar 08, 2010 9:18 am

Re: Link topic to first unread post

Post by VSE » Tue Apr 01, 2014 2:12 am

DavidIQ wrote:I think you're confused. Visiting this:
https://area51.phpbb.com/phpBB/viewtopi ... ead#unread
Which was the link that the topic title was being generated as before the last change, will take you to the last page of the topic after you've read all posts in the topic. It does not take you to the first page.
No confusion

here is the code from that prior PR: https://github.com/phpbb/phpbb/pull/182 ... ca0e85L148

Basically, if there were unread posts, the link is to u_newest_post, else, u_view_topic. Only the icon beside the author name in the last posts column would take you to u_last_post.

The changes made from the prior patch to the current one, changed nothing behaviorally about it other than moving the unread posts logic from the topic title onto the topic icons.
Has an irascible disposition.

User avatar
Pony99CA
Registered User
Posts: 986
Joined: Sun Feb 08, 2009 2:35 am
Location: Hollister, CA
Contact:

Re: Link topic to first unread post

Post by Pony99CA » Tue Apr 01, 2014 3:34 am

John P wrote:Because it's tradition is a very bad argument.
However, "because users are used to it and a change will confuse users" is a good argument.

Steve
Silicon Valley Pocket PC (http://www.svpocketpc.com)
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.

Post Reply