[RFC|Merged] Make ext/ directory

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

[RFC|Merged] Make ext/ directory

Post by EXreaction » Tue Oct 23, 2012 12:32 am

Since board owners will be using the ext/ directory, I believe it should be included as an empty directory in the package.

I think this will prevent any confusion as to where to put extensions if the ext directory does not exist or if they are supposed to create it, etc, from first time board owners.

User avatar
Pony99CA
Registered User
Posts: 986
Joined: Sun Feb 08, 2009 2:35 am
Location: Hollister, CA
Contact:

Re: [RFC] Make ext/ directory

Post by Pony99CA » Tue Oct 23, 2012 1:39 am

Maybe not empty -- you might want a .htaccess file there -- but that's certainly a good idea.

Steve
Silicon Valley Pocket PC (http://www.svpocketpc.com)
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.

User avatar
callumacrae
Infrastructure Team
Infrastructure Team
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [RFC] Make ext/ directory

Post by callumacrae » Tue Oct 23, 2012 1:09 pm

Pony99CA wrote:Maybe not empty -- you might want a .htaccess file there -- but that's certainly a good idea.

Steve
It can't be empty or git won't accept it. I can't see the point in a htaccess, but a .gitignore or .gitkeep would be good.
Made by developers, for developers!
My blog

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1732
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [RFC] Make ext/ directory

Post by DavidIQ » Tue Oct 23, 2012 1:48 pm

Or the usual blank index.htm file.
Image

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Make ext/ directory

Post by imkingdavid » Tue Oct 23, 2012 9:18 pm

DavidIQ wrote:Or the usual blank index.htm file.
Right. I'm not sure we need to add yet another .gitignore, nor do we need a .gitkeep.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: [RFC] Make ext/ directory

Post by EXreaction » Tue Oct 23, 2012 9:29 pm

If nothing inside the ext directory should be accessible, it should be blocked by a .htaccess rule somewhere. Although this probably isn't the case, image files and such may be required within the extension...

Senky
Extension Customisations
Extension Customisations
Posts: 283
Joined: Thu Jul 16, 2009 4:41 pm

Re: [RFC] Make ext/ directory

Post by Senky » Wed Oct 24, 2012 1:57 pm

+1 to RFC idea.

User avatar
Marc
Development Team Leader
Development Team Leader
Posts: 123
Joined: Thu Sep 09, 2010 11:36 am
Location: Munich, Germany

Re: [RFC] Make ext/ directory

Post by Marc » Wed Oct 24, 2012 7:39 pm

+1 for the idea
DavidIQ wrote:Or the usual blank index.htm file.
+1

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1732
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [RFC] Make ext/ directory

Post by DavidIQ » Wed Oct 24, 2012 7:46 pm

EXreaction wrote:If nothing inside the ext directory should be accessible, it should be blocked by a .htaccess rule somewhere. Although this probably isn't the case, image files and such may be required within the extension...
I know my ReIMG MOD when converted to an extension would have images in its directory under /ext/ as they are currently just being copied to each style. There are also some other files included, such as one that is called via AJAX as well as common .js files. These I assume would all need to be in /ext/ and they would obviously need to be accessed outside of this directory. At the moment I have most of the files in a reimg directory in the site root so I'd be moving them.
Image

User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: [RFC] Make ext/ directory

Post by EXreaction » Tue Oct 30, 2012 5:10 pm


Post Reply