[RFC|Merged] Delete "Misc" tab of forum based permissions + move items

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

[RFC|Merged] Delete "Misc" tab of forum based permissions + move items

Post by Oleg » Wed Oct 17, 2012 12:19 pm

Testing https://github.com/phpbb/phpbb3/pull/946 I noticed that the misc tab does not really need to exist.

I would propose moving "can search forum" to "actions" tab and everything else to "post" tab.

While writing this RFC I further noticed that some of the items on "post" tab really should be under "actions", and subsequently "actions" should become the first/default tab displayed. And then I looked at "content" tab, it's also a mess.

I would suggest the following categorization and ordering:

1. "Actions" tab:

can see forum
can read forum
can search forum
can subscribe forum
can print topics
can email topics
can bump topics
can lock own topics
can download files
can report posts

2. "Post" tab:

can start new topics
can post stickies
can post announcements
can reply to topics
can edit own posts
can delete own posts (? - actions?)

3. "Content" tab:

can attach files
can use topic/post icons
can use bbcode
can use flash bbcode
can use img bbcode
can use signatures
can use smilies

4. "Polls" tab (unchanged):

can create polls
can vote in polls
can change existing vote

If this RFC is approved I won't be implementing it but I will merge a PR doing so.

User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: [RFC] Delete "Misc" tab of forum based permissions + move items

Post by EXreaction » Wed Oct 17, 2012 4:41 pm

Do the tabs show if there are no permissions under them? If not, I'd recommend leaving the tab for modifications.

User avatar
Jacob
Registered User
Posts: 100
Joined: Wed Jan 04, 2012 1:41 pm

Re: [RFC] Delete "Misc" tab of forum based permissions + move items

Post by Jacob » Wed Oct 17, 2012 6:19 pm

What about the following?:

1. "Forum" tab:

can see forum
can read forum
can search forum
can subscribe forum

2. "Topic" tab:

can start new topics
can post stickies
can post announcements
can reply to topics
can bump topics
can lock own topics
can print topics
can email topics

3. "Post" tab:

can edit own posts
can delete own posts
can report posts

4. "Content" tab:

can download files
can attach files
can use topic/post icons
can use bbcode
can use flash bbcode
can use img bbcode
can use signatures
can use smilies

5. "Polls" tab (unchanged):

can create polls
can vote in polls
can change existing vote

Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: [RFC] Delete "Misc" tab of forum based permissions + move items

Post by Oleg » Wed Oct 17, 2012 7:42 pm

This is more of an object-centric proposal, whereas mine was more action-centric. Right now I favor the action-centric one (the one in my post).

User avatar
Pony99CA
Registered User
Posts: 986
Joined: Sun Feb 08, 2009 2:35 am
Location: Hollister, CA
Contact:

Re: [RFC] Delete "Misc" tab of forum based permissions + move items

Post by Pony99CA » Thu Oct 18, 2012 2:26 am

Sounds reasonable, but not a big deal. However, if it gets my Logical Permission Ordering RFC implemented, too, I'm more in favor of it. :D

However, neither proposal showed where the MIsc items were positioned (other than Can search forum). Where would Can ignore flood limit, Can post without approval and Increment post counter be placed on the Post tab?

Now that I think about it, I also wonder why Increment post counter is a user/group permission at all instead of a forum option. What use case is there for allowing Group A to have their post counts increase when posting to a forum while not allowing Group B to have theirs increase? It makes more work to turn it off on a forum-specific basis if you have to do it group by group. (You could use a role, but then you have to create or edit that role.)

Steve
Silicon Valley Pocket PC (http://www.svpocketpc.com)
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.

Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: [RFC] Delete "Misc" tab of forum based permissions + move items

Post by Oleg » Thu Oct 18, 2012 2:52 am

I did not see these permissions in my UI, this is why I did not include them. I would either put them on the bottom of post tab after everything else, or after post stickies/announcements.

From your RFC it sounds like getting another ordering at all (doesn't matter what it is as long as it's externally specified, e.g. via an RFC such as this one) is going to be the difficult part.

User avatar
Pony99CA
Registered User
Posts: 986
Joined: Sun Feb 08, 2009 2:35 am
Location: Hollister, CA
Contact:

Re: [RFC] Delete "Misc" tab of forum based permissions + move items

Post by Pony99CA » Thu Oct 18, 2012 8:59 pm

Oleg wrote: From your RFC it sounds like getting another ordering at all (doesn't matter what it is as long as it's externally specified, e.g. via an RFC such as this one) is going to be the difficult part.
Your suggested order was pretty reasonable for the user forum permissions. We just need the rest of the permissions to be ordered logically, too.

Steve
Silicon Valley Pocket PC (http://www.svpocketpc.com)
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.

User avatar
RMcGirr83
Registered User
Posts: 357
Joined: Fri Mar 09, 2007 1:51 am
Contact:

Re: [RFC] Delete "Misc" tab of forum based permissions + move items

Post by RMcGirr83 » Thu Oct 25, 2012 10:41 am

I have this mostly done but not sure if the RFC is accepted or not.
Do not hire Christian Bullock he won't finish the job and will keep your money

User avatar
MichaelC
Development Team
Development Team
Posts: 889
Joined: Thu Jan 28, 2010 6:29 pm

Re: [RFC] Delete "Misc" tab of forum based permissions + move items

Post by MichaelC » Thu Oct 25, 2012 3:50 pm

RMcGirr83 wrote:I have this mostly done but not sure if the RFC is accepted or not.
RFCs don't get accepted anymore, its more a case of finding consensus in the RFC, if a developer agrees a topic leans towards merging it & the patch is good then they will do so.
Formerly known as Unknown Bliss
psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
No unsolicited PMs please except for quotes.

User avatar
RMcGirr83
Registered User
Posts: 357
Joined: Fri Mar 09, 2007 1:51 am
Contact:

Re: [RFC] Delete "Misc" tab of forum based permissions + move items

Post by RMcGirr83 » Thu Oct 25, 2012 6:54 pm

Do not hire Christian Bullock he won't finish the job and will keep your money

Post Reply