[RFC] Responsive layout

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
Post Reply
User avatar
hanakin
Front-End Dev Team Lead
Front-End Dev Team Lead
Posts: 906
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: Responsive layout

Post by hanakin »

What about creating a dynamic template variable something like this for handling some of the responsiveness of certain features that would no doubt require completely different code on mobile or tablets

<!-- ELSEIF RESPONSIVE_WIDTH:940 -->
<!-- INCLUDE large_header.html -->
<!-- ELSEIF RESPONSIVE_WIDTH:768 -->
<!-- INCLUDE base_header.html -->
<!-- ELSE -->
<!-- INCLUDE sm_header.html -->
<!-- ENDIF -->

leverage js through the php to get the width and do a compare prior to include.

This would reduce the amount of code needed to be rendered for mobile devices and tablets and still allow for traditional responsive design for the desktop and widescreens
Donations welcome via Paypal Image

aleha
Registered User
Posts: 143
Joined: Tue Mar 26, 2013 2:19 am

Re: Responsive layout

Post by aleha »

What is the status of this RFC?
Will prosilver be responsive in 3.1?

From what I understand it's either a mobile theme or a responsive one but not both, right? Or this can be done but it's not advisable?

User avatar
Arty
Former Team Member
Posts: 985
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: Responsive layout

Post by Arty »

Its work in progress. Some other improvements needed to make responsive layout work have been merged.

User avatar
Arty
Former Team Member
Posts: 985
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: Responsive layout

Post by Arty »

Now that stuff required to make responsive design work has been merged, I've started working on responsive design for prosilver.
Pull request: https://github.com/phpbb/phpbb3/pull/1719

Its work in progress. So far only wrapper, menu, ucp/mcp navigation and forums/topic lists are done.

Some functions (links lists, breadcrumbs, tabs) use JavaScript to make layout cleaner. That JavaScript is not required, it is there only to enhance experience for js enabled browsers.

Please report any bugs you'll find.

User avatar
hanakin
Front-End Dev Team Lead
Front-End Dev Team Lead
Posts: 906
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: Responsive layout

Post by hanakin »

intrigued ill look at it when i can ;)
Donations welcome via Paypal Image

keith10456
Registered User
Posts: 523
Joined: Sat Apr 22, 2006 10:29 pm
Contact:

Re: Responsive layout

Post by keith10456 »

@Arty - Very glad to hear it... Thanks ;-)

aleha
Registered User
Posts: 143
Joined: Tue Mar 26, 2013 2:19 am

Re: Responsive layout

Post by aleha »

Indeed these are great news!

Arty, I undestand this is work in progress but if you go responsive with prosilver then you will most probably discontinue your mobile prosilver theme for 3.1?

User avatar
Arty
Former Team Member
Posts: 985
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: Responsive layout

Post by Arty »

Thanks. Please report any bugs. If you notice something looks like it was made responsive yet it doesn't behave correctly, it is most likely a bug.
aleha wrote:Arty, I undestand this is work in progress but if you go responsive with prosilver then you will most probably discontinue your mobile prosilver theme for 3.1?
While mobile style and responsive design aren't mutually exclusive, working on both is just a waste of time. So yep, mobile style will not be updated.

User avatar
nextgen
Registered User
Posts: 128
Joined: Sat Jul 24, 2010 4:59 am
Location: Guatemala
Contact:

Re: Responsive layout

Post by nextgen »

I've made these changes to test the style, Although I think that I have done something wrong because not shown fine in mobile style.
I leave a test user for which you want to see the results more thoroughly.
index.jpg
(59.5 KiB) Downloaded 1680 times
User: testuser
Password: 123456

Edit: http://dev.orbitstudios.net/index.php
Last edited by nextgen on Mon Oct 07, 2013 7:00 pm, edited 1 time in total.
*Imagine a signature super spectacular.*

User avatar
Arty
Former Team Member
Posts: 985
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: Responsive layout

Post by Arty »

Looks like a bug. What's the URL of that test board?

Post Reply