[RFC] Responsive layout

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
Post Reply
User avatar
Jessica.
Registered User
Posts: 144
Joined: Wed Feb 09, 2011 8:17 pm
Location: Pennsylvania, USA
Contact:

Re: Responsive layout

Post by Jessica. » Mon Oct 28, 2013 4:40 pm

Just wondering, where/when is the icon_post_menu.png supposed to appear? I have yet to see it :/

(or wait, is it because Area51 needs to be updated or something?)

User avatar
Arty
Registered User
Posts: 972
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: Responsive layout

Post by Arty » Mon Oct 28, 2013 4:45 pm

Instead of quote/edit/etc buttons in post when there is not enough space to fit all buttons.

User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 670
Joined: Mon Mar 08, 2010 9:18 am

Re: Responsive layout

Post by VSE » Mon Oct 28, 2013 5:27 pm

In the ACP Responsive changes, the modal overlay is not fully overlaid anymore... lots of elements poke through (tabs at top, URL links on the left, the vertical line separating the links on the left from the main part of page)
Attachments
Resposive_acp2.png
(115.91 KiB) Downloaded 2424 times
Has an irascible disposition.

User avatar
Arty
Registered User
Posts: 972
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: Responsive layout

Post by Arty » Mon Oct 28, 2013 6:00 pm

Thanks for noticing. I'll fix that.

Please post here if you'll see anything else not working correctly

User avatar
Arty
Registered User
Posts: 972
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: Responsive layout

Post by Arty » Mon Oct 28, 2013 6:20 pm


MaFeSa
Registered User
Posts: 69
Joined: Sun Aug 26, 2012 1:44 pm

Re: Responsive layout

Post by MaFeSa » Mon Oct 28, 2013 8:39 pm

Arty wrote:Fixed
Thanks Arty!
Is possibile to add a little space between pages and number of message?
Attachments
image.jpg
(48.59 KiB) Downloaded 2664 times
image.jpg
image.jpg (29.71 KiB) Viewed 7780 times

User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 670
Joined: Mon Mar 08, 2010 9:18 am

Re: Responsive layout

Post by VSE » Mon Oct 28, 2013 10:18 pm

Arty wrote:@VSE+ Fix for that bug: https://github.com/phpbb/phpbb/pull/1832
Thanks. But still sort of an issue - now those elements flash when you click on something that brings up the modal.

Video demonstration: http://youtu.be/iVL1jQ3F4Zc
Has an irascible disposition.

User avatar
Arty
Registered User
Posts: 972
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: Responsive layout

Post by Arty » Mon Oct 28, 2013 11:03 pm

Looks like a browser bug. What browser are you using?

User avatar
Arty
Registered User
Posts: 972
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: Responsive layout

Post by Arty » Mon Oct 28, 2013 11:21 pm

Actually its not a browser bug. Its a bug in AJAX popup animation that happens when there are absolutely positioned elements with z-index. Same issue happens in prosilver as well.

It wasn't noticed in prosilver because it doesn't have items with z-index by default.

Fixed in https://github.com/phpbb/phpbb/pull/1834

User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 670
Joined: Mon Mar 08, 2010 9:18 am

Re: Responsive layout

Post by VSE » Tue Oct 29, 2013 9:48 pm

Found another bug introduced during this commit: https://github.com/phpbb/phpbb/commit/5 ... 2032d6f485

There are now stray closing </ul> tags in adm/style/overall_header.html.

They are happening in the left sidebar.

Just HTML Validate any ACP page to find the stray </ul> tag.
Has an irascible disposition.

Post Reply