[RFC|Merged] Template Events

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: [RFC] Template Events

Post by EXreaction » Thu Oct 11, 2012 1:35 am

Yes, is anyone working on this or planning to work on this?

Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: [RFC] Template Events

Post by Oleg » Thu Oct 11, 2012 3:06 am

No promises at this time.

User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: [RFC] Template Events

Post by EXreaction » Thu Oct 11, 2012 4:44 pm

imkingdavid, were you going to work on this? That was my understanding, if not I can take a look at it.

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Template Events

Post by imkingdavid » Thu Oct 11, 2012 6:02 pm

EXreaction wrote:imkingdavid, were you going to work on this? That was my understanding, if not I can take a look at it.
To be honest, I wouldn't know where to start. No offense to Oleg but his PR appears to be a mess with quite a bit of debugging code and such. I can see what I can do, but you're welcome to take a stab as well.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: [RFC] Template Events

Post by EXreaction » Mon Oct 15, 2012 1:22 am

I'm working on this. I have the resource locator working properly and everything in the core, but I'm having an issue with the test case.

The problem is that in the test case, for some reason, the "trivial" extension that is used does not come up under the list of roots in the resource locator. I've been trying to figure out how the extension directories are added to that list of roots, but I cannot find anything that assigns them, anyone have any hints?

I've created a new PR: https://github.com/phpbb/phpbb3/pull/1010

User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: [RFC] Template Events

Post by EXreaction » Mon Oct 15, 2012 3:08 am

Actually, it's far more complicated than that.

I believe the main issue I'm getting now is due to the finder in the extensions, since the style path is not in the phpbb root path. I'm working on it, but it's a lot to go through and figure out how to appropriately fix...

User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: [RFC] Template Events

Post by EXreaction » Mon Oct 15, 2012 3:47 am

I believe I've solved it now and I think template events are ready for merging: https://github.com/phpbb/phpbb3/pull/1010

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Template Events

Post by imkingdavid » Mon Oct 15, 2012 1:51 pm

I have reviewed it and it looks fine to me other than the items I pointed out. I still need to test it, but IMO if it works it can be merged.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: [RFC] Template Events

Post by EXreaction » Mon Oct 15, 2012 2:05 pm

Which items are you specifically referring to? :)

EDIT: Nevermind, I see on Github, I thought you were talking about this thread.

Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: [RFC] Template Events

Post by Oleg » Thu Dec 06, 2012 7:17 am

Tests now pass therefore either additional test cases need to be devised or the pull request should be merged.

https://github.com/phpbb/phpbb3/pull/764

Post Reply