[RFC] HTML5 input types for form fields

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
User avatar
callumacrae
Infrastructure Team
Infrastructure Team
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [RFC] HTML5 input types for form fields

Post by callumacrae » Tue Aug 07, 2012 9:00 am

Pony99CA wrote:As long as "legacy" browsers still work with the new field types, I don't see much downside to this.
They fall back to text (much like "eahobn" inputs), so would be fine.
Made by developers, for developers!
My blog

User avatar
Pony99CA
Registered User
Posts: 986
Joined: Sun Feb 08, 2009 2:35 am
Location: Hollister, CA
Contact:

Re: [RFC] HTML5 input types for form fields

Post by Pony99CA » Tue Aug 07, 2012 9:41 pm

callumacrae wrote:...(much like "eahobn" inputs)....
The what? Google couldn't even find "eahobn". I'm guessing that means the HTML 4.x standard INPUT tag types, but those are:

button
checkbox
file
hidden
image
password
radio
reset
submit
text

I could guess "Edit/Area/Hidden/Option/Button" but still don't get the "n".

Anyway, I presume that phpBB would keep the server validation for those fields to cope with those legacy browsers that didn't do client-side validation.

Steve
Silicon Valley Pocket PC (http://www.svpocketpc.com)
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.

User avatar
keith10456
Registered User
Posts: 523
Joined: Sat Apr 22, 2006 10:29 pm
Contact:

Re: [RFC] HTML5 input types for form fields

Post by keith10456 » Tue Aug 07, 2012 11:39 pm

+1 (for HTML5 input types for form fields)

User avatar
callumacrae
Infrastructure Team
Infrastructure Team
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [RFC] HTML5 input types for form fields

Post by callumacrae » Wed Aug 08, 2012 8:08 am

Pony99CA wrote:
callumacrae wrote:...(much like "eahobn" inputs)....
The what? Google couldn't even find "eahobn". I'm guessing that means the HTML 4.x standard INPUT tag types, but those are:

button
checkbox
file
hidden
image
password
radio
reset
submit
text

I could guess "Edit/Area/Hidden/Option/Button" but still don't get the "n".

Anyway, I presume that phpBB would keep the server validation for those fields to cope with those legacy browsers that didn't do client-side validation.

Steve
I'm glad it doesn't exist, that would have really screwed up my point! :-D

My point was that the HTML input was designed in such a way to be backwards compatible - if the input type is not recognised, it falls back to text.

http://jsfiddle.net/TNgnx/
Made by developers, for developers!
My blog

Senky
Extension Customisations
Extension Customisations
Posts: 283
Joined: Thu Jul 16, 2009 4:41 pm

Re: [RFC] HTML5 input types for form fields

Post by Senky » Wed Aug 08, 2012 6:11 pm

Developing PR (with confirmation of Vinny) for this ticket, I found out that all includes/acp/acp_* files use build_cfg_template() from adm/index.php, not from includes/functions_acp.php. Can someone explain it to me? How I am going to treat that? Am I to add new input types into both locations of the function, or change all includes/acp/acp_* files not to use index.php, but functions_acp.php file?

EDIT: sorry, I combined directories of 3.0 and 3.1 and did not realise 3.1 does not have any function in adm/index.php. No problems from now.

User avatar
Pony99CA
Registered User
Posts: 986
Joined: Sun Feb 08, 2009 2:35 am
Location: Hollister, CA
Contact:

Re: [RFC] HTML5 input types for form fields

Post by Pony99CA » Wed Aug 08, 2012 9:39 pm

callumacrae wrote:I'm glad it doesn't exist, that would have really screwed up my point! :-D
Ah, got it. I thought that you were using "eahobn" as an abbreviation, but you were just using it as a non-existent input type. :oops:

Steve
Silicon Valley Pocket PC (http://www.svpocketpc.com)
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.

User avatar
Vinny
Style Customisations
Style Customisations
Posts: 126
Joined: Thu May 20, 2010 4:01 am
Location: Brazil
Contact:

Re: [RFC] HTML5 input types for form fields

Post by Vinny » Sat Aug 11, 2012 12:20 am

Senky and me are working on this change. You can follow our progress in this branch.

We appreciate any feedback. :)

User avatar
keith10456
Registered User
Posts: 523
Joined: Sat Apr 22, 2006 10:29 pm
Contact:

Re: [RFC] HTML5 input types for form fields

Post by keith10456 » Sat Aug 11, 2012 6:12 pm

Vinny wrote:Senky and me are working on this change. You can follow our progress in this branch.

We appreciate any feedback. :)
8-)

Michaelo
Registered User
Posts: 106
Joined: Thu Apr 01, 2004 7:56 am
Location: Dublin

Re: [RFC] HTML5 input types for form fields

Post by Michaelo » Wed Aug 29, 2012 3:17 pm

FYI Most major browsers with the exception of IE9 and Safari currently support client side form validation... IE 10 also supports it...
Mods: Forum Icons Enhancement, Kiss Portal Engine
Links:
Kiss Portal Engine (dev site) Stargate Portal (archive site) ...
Styles: Technika

User avatar
callumacrae
Infrastructure Team
Infrastructure Team
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [RFC] HTML5 input types for form fields

Post by callumacrae » Wed Aug 29, 2012 5:31 pm

Michaelo wrote:FYI Most major browsers with the exception of IE9 and Safari currently support client side form validation... IE 10 also supports it...
What do you mean by client-side form validation? It's possible to validate the contents of a form in any browser… so I'm assuming that that isn't what you meant.
Made by developers, for developers!
My blog

Post Reply