[RFC] HTML5 input types for form fields

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
User avatar
Vinny
Style Customisations
Style Customisations
Posts: 126
Joined: Thu May 20, 2010 4:01 am
Location: Brazil
Contact:

[RFC] HTML5 input types for form fields

Post by Vinny » Fri Jul 20, 2012 11:48 pm

Everyone knows that the phpBB 3.1 uses HTML5, thinking about it why not use the new features? The discussion about the new features started here.

Proposal
Add the new input types for forms. With the new HTML5 input types, you can have more control over each field, well as validating email and url fields.

Pros
The browser will automatically take care to validate the fields.

Cons
Browsers support :| . Some browser doesn't support some types. But the current error box system will remain. :P

Ticket: http://tracker.phpbb.com/browse/PHPBB3-11010
PR: https://github.com/phpbb/phpbb3/pull/1000/

User avatar
nextgen
Registered User
Posts: 128
Joined: Sat Jul 24, 2010 4:59 am
Location: Guatemala
Contact:

Re: [RFC] HTML5 input types for form fields

Post by nextgen » Sat Jul 21, 2012 12:42 am

Vinny wrote:Cons
Browsers support :| . Some browser doesn't support some types.
In this case only is Internet explorer, Firefox, Opera, Safari and Chrome already support the features of HTML5
Vinny wrote:Proposal
Add the new input types for forms. With the new HTML5 input types, you can have more control over each field, well as validating email and url fields.
+1
*Imagine a signature super spectacular.*

User avatar
Vinny
Style Customisations
Style Customisations
Posts: 126
Joined: Thu May 20, 2010 4:01 am
Location: Brazil
Contact:

Re: [RFC] HTML5 input types for form fields

Post by Vinny » Sat Jul 21, 2012 1:02 am

nextgen wrote:In this case only is Internet explorer, Firefox, Opera, Safari and Chrome already support the features of HTML5
Unknown Bliss wrote:FYI: http://fmbip.com/ tells you about your current browser compatibility.
Also, look this: http://www.w3schools.com/html5/html5_fo ... _types.asp

User avatar
naderman
Product Manager
Product Manager
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC] HTML5 input types for form fields

Post by naderman » Sat Jul 21, 2012 10:39 am

Seems straight forward, and even if some browser doesn't support one of them yet, worst case it'll look like it does now. So I think all we need here is for someone to create a ticket and someone who wants to implement it who will send a pull request.

User avatar
Vinny
Style Customisations
Style Customisations
Posts: 126
Joined: Thu May 20, 2010 4:01 am
Location: Brazil
Contact:

Re: [RFC] HTML5 input types for form fields

Post by Vinny » Sat Jul 21, 2012 5:22 pm

naderman wrote:Seems straight forward, and even if some browser doesn't support one of them yet, worst case it'll look like it does now.
Yes, good point.
naderman wrote:So I think all we need here is for someone to create a ticket and someone who wants to implement it who will send a pull request.
Ticket = Done
PR = I'm working in the pr.

User avatar
Vinny
Style Customisations
Style Customisations
Posts: 126
Joined: Thu May 20, 2010 4:01 am
Location: Brazil
Contact:

Re: [RFC] HTML5 input types for form fields

Post by Vinny » Mon Aug 06, 2012 12:28 am

I was reviewing and testing the new types and I think that just email and url should be used.

Opinions?

User avatar
A_Jelly_Doughnut
Registered User
Posts: 1780
Joined: Wed Jun 04, 2003 4:23 pm

Re: [RFC] HTML5 input types for form fields

Post by A_Jelly_Doughnut » Mon Aug 06, 2012 12:42 am

I could certainly see scenarios where date, datetime, and tel[ephone] would be useful, although only date is currently implemented as a CPF type.
A_Jelly_Doughnut

User avatar
Vinny
Style Customisations
Style Customisations
Posts: 126
Joined: Thu May 20, 2010 4:01 am
Location: Brazil
Contact:

Re: [RFC] HTML5 input types for form fields

Post by Vinny » Mon Aug 06, 2012 1:42 am

Maybe number and search too.

User avatar
callumacrae
Infrastructure Team
Infrastructure Team
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [RFC] HTML5 input types for form fields

Post by callumacrae » Mon Aug 06, 2012 7:19 am

The search input annoyed me because it wasn't themeable. I couldn't get rid if the overly-rounded corners.
Made by developers, for developers!
My blog

User avatar
Pony99CA
Registered User
Posts: 986
Joined: Sun Feb 08, 2009 2:35 am
Location: Hollister, CA
Contact:

Re: [RFC] HTML5 input types for form fields

Post by Pony99CA » Tue Aug 07, 2012 2:22 am

naderman wrote:Seems straight forward, and even if some browser doesn't support one of them yet, worst case it'll look like it does now.
As long as "legacy" browsers still work with the new field types, I don't see much downside to this. It might also make my New Custom Profile Field Types RFC easier (in the future; for now, validation will still be required anyway).
A_Jelly_Doughnut wrote:I could certainly see scenarios where date, datetime, and tel[ephone] would be useful, although only date is currently implemented as a CPF type.
CPF? UPDATE: Never mind -- Custom Profile Field.

The Month type could be used for birth dates and the Color type in the ACP (for example, the Group colour setting).

Steve
Silicon Valley Pocket PC (http://www.svpocketpc.com)
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.

Post Reply