[RFC|Merged] Pagination as <ul> list

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
User avatar
oddfish
Registered User
Posts: 110
Joined: Tue Mar 27, 2007 5:53 am
Location: on my way home
Contact:

Re: [RFC|Merged] Pagination as <ul> list

Post by oddfish » Sun Jul 22, 2012 6:44 pm

I was meaning the excessive tabs and extra space introduced in the code. Apologies for any confusion.

User avatar
psoTFX
Registered User
Posts: 1984
Joined: Tue Jul 03, 2001 8:50 pm
Contact:

Re: [RFC|Merged] Pagination as <ul> list

Post by psoTFX » Sun Jul 22, 2012 7:06 pm

As I say - my preference is to have readable templates - as opposed to page source which may have some extra newlines. Have you looked at pagination.html? I imagine you'll see why those extra newlines exist. If they shouldn't be there then I'll happily alter said templates - but it'll be at the expense of their readability.

User avatar
naderman
Product Manager
Product Manager
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC|Merged] Pagination as <ul> list

Post by naderman » Sun Jul 22, 2012 7:26 pm

That really just doesn't need an RFC, ticket and implementation will do. I imagine that's why he brought it up here. In case someone looking at pagination stuff felt like implementing it.

Post Reply