[RFC|Merged] Pagination as <ul> list

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
User avatar
paulus
Infrastructure Team Leader
Infrastructure Team Leader
Posts: 361
Joined: Thu Sep 16, 2004 9:02 am
Contact:

Re: [RFC|Merged] Pagination as <ul> list

Post by paulus » Sat Jul 21, 2012 2:57 pm

The previous/next buttons are gone in at least viewtopic now at the bottom, I guess caused by this merged change, http://tracker.phpbb.com/browse/PHPBB3-11014
Image

User avatar
psoTFX
Registered User
Posts: 1984
Joined: Tue Jul 03, 2001 8:50 pm
Contact:

Re: [RFC|Merged] Pagination as <ul> list

Post by psoTFX » Sat Jul 21, 2012 4:58 pm

Indeed - the previous/next were set in the old pagination function I completely missed that. I'll add back that functionality (minus the template prefix stuff which afaik isn't used anywhere and is non-existent now anyway) via phpbb_on_page.

User avatar
Meis2M
Registered User
Posts: 411
Joined: Fri Apr 23, 2010 10:18 am
Contact:

Re: [RFC|Merged] Pagination as <ul> list

Post by Meis2M » Sat Jul 21, 2012 8:10 pm

psoTFX you are one of the old phpBB user.
maybe you are one of the phpBB father. 11 years ago you registered in phpbb. ( oh my god ) 11 years ago i was a kid and i did not know what is internet. :D
how old are u ?

User avatar
psoTFX
Registered User
Posts: 1984
Joined: Tue Jul 03, 2001 8:50 pm
Contact:

Re: [RFC|Merged] Pagination as <ul> list

Post by psoTFX » Sat Jul 21, 2012 8:14 pm

465 - give or take a day or two :P

User avatar
naderman
Product Manager
Product Manager
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC|Merged] Pagination as <ul> list

Post by naderman » Sun Jul 22, 2012 12:05 am

Seeing that bug it might be nice to also add some functional tests. For example to check that pagination exists and works correctly on viewtopic & viewforum. If you feel like getting into the functional testing framework ;-)

User avatar
oddfish
Registered User
Posts: 110
Joined: Tue Mar 27, 2007 5:53 am
Location: on my way home
Contact:

Re: [RFC|Merged] Pagination as <ul> list

Post by oddfish » Sun Jul 22, 2012 7:46 am

http://tracker.phpbb.com/browse/PHPBB3-11018 and line 395 in viewonline.php 'PAGINATION' => $pagination, causes some issues from the pagination update in general.

User avatar
psoTFX
Registered User
Posts: 1984
Joined: Tue Jul 03, 2001 8:50 pm
Contact:

Re: [RFC|Merged] Pagination as <ul> list

Post by psoTFX » Sun Jul 22, 2012 2:06 pm

The offset in the styling is something I'll look at ... again ... proSilver is a pita. Will look @ the viewonline issue, thought I'd removed all the PAGINATION assignments, so much for search and replace :D The white space issue - possible I'm not up to date but imho it's of little to no consequence and just due to the way the pagination conditional statements are laid out. Personally I'd rather have the templates readable.

User avatar
naderman
Product Manager
Product Manager
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC|Merged] Pagination as <ul> list

Post by naderman » Sun Jul 22, 2012 2:33 pm

Which white space issues are you talking about? Is this related to memberlist as well? But yeah i agree, readability & over brevity ;-)

User avatar
brunoais
Registered User
Posts: 958
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC|Merged] Pagination as <ul> list

Post by brunoais » Sun Jul 22, 2012 5:16 pm

bantu wrote:It has been brought to my attention that http://www.phpbb.com/community/viewtopi ... &t=2140429 might be a good idea to implement.
+1

User avatar
psoTFX
Registered User
Posts: 1984
Joined: Tue Jul 03, 2001 8:50 pm
Contact:

Re: [RFC|Merged] Pagination as <ul> list

Post by psoTFX » Sun Jul 22, 2012 5:42 pm

Not sure that belongs with this RFC which was about moving the source rendered pagination code to the template - that's been achieved. Seems this is really a new (or bumped existing?) RFC.

Post Reply