[RFC|Merged] Javascript Coding Style

[naderman]

Anyone going to make a pull request for the coding guidelines to add a section about javascript with what is proposed here?

[callumacrae]

Anyone going to make a pull request for the coding guidelines to add a section about javascript with what is proposed here?

Doing it now.

[_hsr]

@callum, I'd like to work on writing the guidelines too, enlighten me with the source :p

[Fyorl]

I'd like to revisit the discussion on curly braces in Javascript since it didn't seem to get resolved in the previous pages. It was already established that braces on their own line looked ugly for anonymous functions and also caused bugs/errors when attempting to return an object. In this case, it feels inconsistent to have one style of curly braces for objects and lambdas but another for named functions and block statements. Would it not be simpler to just say that, in Javascript files, the opening curly brace should be on the same line?

[naderman]

I think we really should stop adding more things to this RFC and just start new ones whenever new things come up. Does someone feel like splitting up recent posts into separate discussions?

[brunoais]

Does someone feel like splitting up recent posts into separate discussions?

I do.

[callumacrae]

I'd like to revisit the discussion on curly braces in Javascript since it didn't seem to get resolved in the previous pages. It was already established that braces on their own line looked ugly for anonymous functions and also caused bugs/errors when attempting to return an object. In this case, it feels inconsistent to have one style of curly braces for objects and lambdas but another for named functions and block statements. Would it not be simpler to just say that, in Javascript files, the opening curly brace should be on the same line?

That's what was decided, and I have an open pull request for it here: https://github.com/phpbb/phpbb3/pull/779

I think we really should stop adding more things to this RFC and just start new ones whenever new things come up. Does someone feel like splitting up recent posts into separate discussions?

Done (ish).

[naderman]

The PR has been merged.