[RFC|Merged] notification box

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
Post Reply
User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC|Merged] notification box

Post by imkingdavid » Tue Oct 15, 2013 8:16 pm

Alien_Time wrote:
*Daniel wrote:Well if phpBB going have @user tagging, we can't have PM going into people's inbox otherwise they will fill up. Not only that if we are going to have other features where there will be some sort of notification, we would need somewhere to put then.
Is it possible to have the notification show for all Topic replies that the user is subscribed to or have enabled the 'Notify me when a reply is posted' option instead of just notifying only the posts with @user tag?
Actually, right now the @user notification is not implemented. It does notify you when you are quoted, if you select that option. More notification types can be added to the core, as well as by extensions (since the notification system is modular and extensible). If you want to see a certain notification type in the core, please create an RFC. :)
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
keith10456
Registered User
Posts: 523
Joined: Sat Apr 22, 2006 10:29 pm
Contact:

Re: [RFC|Merged] notification box

Post by keith10456 » Tue Oct 15, 2013 8:37 pm

imkingdavid wrote:I would personally be fine with dropping the distinction between new and unread, and just show the number of unread. But I'd like a second opinion from another developer.
Just unread. No need to show both... It takes-up too much space.

User avatar
keith10456
Registered User
Posts: 523
Joined: Sat Apr 22, 2006 10:29 pm
Contact:

Re: [RFC|Merged] notification box

Post by keith10456 » Tue Oct 15, 2013 8:39 pm

VSE+ wrote:Streamlined/Improved PMs and Notifications in the Header Link List PR: https://github.com/phpbb/phpbb3/pull/1781

The appearance:

Prosilver
Screen Shot 2013-10-15 at 10.35.10 AM.png
Subsilver2
Screen Shot 2013-10-15 at 10.35.41 AM.png
PMs count the number of unread messages in your Inbox
Great job! I like it ;-)

User avatar
keith10456
Registered User
Posts: 523
Joined: Sat Apr 22, 2006 10:29 pm
Contact:

Re: [RFC|Merged] notification box

Post by keith10456 » Tue Oct 15, 2013 8:41 pm

keith10456 wrote:
VSE+ wrote:Streamlined/Improved PMs and Notifications in the Header Link List PR: https://github.com/phpbb/phpbb3/pull/1781

The appearance:

Prosilver
Screen Shot 2013-10-15 at 10.35.10 AM.png
Subsilver2
Screen Shot 2013-10-15 at 10.35.41 AM.png
PMs count the number of unread messages in your Inbox
Great job! I like it ;-)

[offtopic]
Now if only we can get the verbiage "User Control Panel" to go away...
[/offtopic]

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC|Merged] notification box

Post by imkingdavid » Tue Oct 15, 2013 8:52 pm

keith10456 wrote:
keith10456 wrote:
VSE+ wrote:Streamlined/Improved PMs and Notifications in the Header Link List PR: https://github.com/phpbb/phpbb3/pull/1781

The appearance:

Prosilver
Screen Shot 2013-10-15 at 10.35.10 AM.png
Subsilver2
Screen Shot 2013-10-15 at 10.35.41 AM.png
PMs count the number of unread messages in your Inbox
Great job! I like it ;-)

[offtopic]
Now if only we can get the verbiage "User Control Panel" to go away...
[/offtopic]
What would you suggest as alternative? The main issue, I believe, is that "UCP" is unfamiliar to new users. If you have a better suggestion, please create a new RFC and we can discuss it there.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 670
Joined: Mon Mar 08, 2010 9:18 am

Re: [RFC|Merged] notification box

Post by VSE » Wed Oct 16, 2013 1:34 am

Are brackets around the PM/Notification count #'s better than parenthesis? The Logout [ username ] in the linklist uses brackets, so maybe this is a little more consistent looking?
Screen Shot 2013-10-15 at 6.33.15 PM.png
(37.65 KiB) Downloaded 2037 times
Has an irascible disposition.

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC|Merged] notification box

Post by imkingdavid » Wed Oct 16, 2013 5:31 am

I kind of like brackets better than parenthesis after seeing that screenshot.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
Kamahl19
Registered User
Posts: 161
Joined: Thu Dec 27, 2007 10:31 am

Re: [RFC|Merged] notification box

Post by Kamahl19 » Wed Oct 16, 2013 10:43 am

I am happy we are going to get rid of "new messages", finally. Moreover, it seems no developer liked new messages count, so I dont know why was it added :D
I like VSE's work, but I also agree with replacing envelope with bell for notification. It just makes more sense. However not the black bell as posted above.
I like () more then [] for both count and username, but thats just my opinion.
I also think User control panel should be replaced in 3.1. phpBB should use more common terms like Account, Account settings, Settings or Manage account ..

OT: Right know in this topic, I would be so happy for this feature https://www.phpbb.com/ideas/idea.php?id=55 . I have read 3 pages and wanted to comment 6 or 7 different things, but until I get to the end of the topic, I forgot half of them :D

User avatar
Pete77s
Registered User
Posts: 43
Joined: Mon Feb 07, 2005 4:55 am

Re: [RFC|Merged] notification box

Post by Pete77s » Wed Oct 16, 2013 1:15 pm

The brackets do look good, +1.

Quick OT: I don't recall a user of my forum ever getting confused with "UCP" as link name to account settings. I've even once used just an 16x16 cogwheel icon-- big hint in img alt title.

User avatar
keith10456
Registered User
Posts: 523
Joined: Sat Apr 22, 2006 10:29 pm
Contact:

Re: [RFC|Merged] notification box

Post by keith10456 » Wed Oct 16, 2013 9:04 pm

imkingdavid wrote:
keith10456 wrote:
keith10456 wrote:
VSE+ wrote:Streamlined/Improved PMs and Notifications in the Header Link List PR: https://github.com/phpbb/phpbb3/pull/1781

The appearance:

Prosilver
Screen Shot 2013-10-15 at 10.35.10 AM.png
Subsilver2
Screen Shot 2013-10-15 at 10.35.41 AM.png
PMs count the number of unread messages in your Inbox
Great job! I like it ;-)

[offtopic]
Now if only we can get the verbiage "User Control Panel" to go away...
[/offtopic]
What would you suggest as alternative? The main issue, I believe, is that "UCP" is unfamiliar to new users. If you have a better suggestion, please create a new RFC and we can discuss it there.
Done... See here

@ VSE+ - I like the brackets better. Keep it uniform (with the username link) ;-)

Post Reply