[RFC|Merged] notification box

[Dragosvr92]

Hmm.. Good question !
I think the block should be a link. You can access the user link and message/notification link from the main notification block.

[keith10456]

Hmm.. Good question !
I think the block should be a link. You can access the user link and message/notification link from the main notification block.

Agreed... In my opinion the whole block should be a link. Doing so will make it very mobile (phones, tablets, etc) friendly.

[EXreaction]

It already is.

[keith10456]

It already is.

Glad to hear it!

[shoes22]

Hey, thanks for the hard work. I'm trying to test this out, and I'm getting a fatal error when trying to install and populate the tables. It has to do with the key length.
Here's what I get:

Code: Select all

install_install.php [ 1169 ]
SQL : CREATE TABLE phpbb_user_notifications ( item_type varchar(255) DEFAULT '' NOT NULL, item_id mediumint(8) UNSIGNED DEFAULT '0' NOT NULL, user_id mediumint(8) UNSIGNED DEFAULT '0' NOT NULL, method varchar(255) DEFAULT '' NOT NULL, notify tinyint(1) UNSIGNED DEFAULT '1' NOT NULL, PRIMARY KEY (item_type, item_id, user_id, method) ) CHARACTER SET `utf8` COLLATE `utf8_bin`
Specified key was too long; max key length is 1000 bytes

[RMcGirr83]

utf8 uses 3 bytes per character, latin1 uses 1 byte per character. I am not sure if item_type and method need a varchar of 255.

[EXreaction]

What database system and version are you using?

[Meis2M]

when notification system merge?

[EXreaction]

When someone reviews it.

[shoes22]

What database system and version are you using?

I'm using MySQL with MySQLi, version 5.1.65.

Like RmCGirr83 pointed out, the problem stems from all four columns being primary keys, as that exceeds 1000 bytes in UTF-8.
However, I was able to bypass this issue by importing the table manually (not from install) and changing the 2 varchar columns to varbinary.