[RFC|Merged] notification box

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
Post Reply
User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: [RFC] notification box

Post by EXreaction » Thu Sep 13, 2012 2:18 pm

Exactly what Senky said. It needs some javascript helper that allows you to select the username and insert it into the post, along with some sort of bbcode that can be matched with any containing data.

Two examples that would be fairly difficult and could cause issues with just @:
@a new user
@bl@h

If it uses something like [tag]a new user[/tag] then it's easy, but that requires custom bbcode, which is outside the scope of this.

User avatar
callumacrae
Former Team Member
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [RFC] notification box

Post by callumacrae » Thu Sep 13, 2012 4:36 pm

Yeah, but that looks horrific. @bl@h is fine, it's just usernames with spaces that would cause a problem, and there aren't many of them (it also causes problems on websites such as Stack Overflow, and they're dealing with it fine).

Can I suggest that we take this to the actual RFC? :-D
Made by developers, for developers!
My blog

User avatar
Pony99CA
Registered User
Posts: 986
Joined: Sun Feb 08, 2009 2:35 am
Location: Hollister, CA
Contact:

Re: [RFC] notification box

Post by Pony99CA » Thu Sep 13, 2012 8:15 pm

EXreaction wrote:If it uses something like [tag]a new user[/tag] then it's easy, but that requires custom bbcode, which is outside the scope of this.
Or you add a new pre-defined BBCode for this. ;) Then you could make clicking user names in the topic history display a menu to either view the person's profile or tag the user.

But that's probably outside the scope of this RFC as you said.

Steve
Silicon Valley Pocket PC (http://www.svpocketpc.com)
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.

User avatar
Pony99CA
Registered User
Posts: 986
Joined: Sun Feb 08, 2009 2:35 am
Location: Hollister, CA
Contact:

Re: [RFC] notification box

Post by Pony99CA » Fri Sep 14, 2012 1:37 am

I also hope that this would be used to notify moderators that they had posts awaiting approval. (Wasn't there an RFC for that?) You may not want them getting subscription notifications, but in-board notifications would be great.

Steve
Silicon Valley Pocket PC (http://www.svpocketpc.com)
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.

User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: [RFC] notification box

Post by EXreaction » Fri Sep 14, 2012 2:08 am

Yes, that is planned.

User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: [RFC] notification box

Post by EXreaction » Sat Sep 15, 2012 7:44 pm

It's at a state where it can start being tested more. See the opening post for the PR to see what's in it and what's left to do.
https://github.com/phpbb/phpbb3/pull/992

All the notification types that have been requested (besides username tagging) have been included so far.

User avatar
oddfish
Registered User
Posts: 110
Joined: Tue Mar 27, 2007 5:53 am
Location: on my way home
Contact:

Re: [RFC] notification box

Post by oddfish » Sun Sep 16, 2012 1:43 am

Suggestions on "Prettify"
  1. Remove extended hover colour and line including the brackets on the [ Notifications ] in overall_header.html by removing [] around language string, adding them to overall_header.html [&nbsp;<a href="#" title="{L_NOTIFICATIONS}" onClick="$('#notification_list').toggle();">{L_NOTIFICATIONS}</a>&nbsp;]. This will then give you [ Notifications ]. Might require &bull; to separate UCP and (..Messages).
  2. Grey background in notification needs a bertification somewhat (much prefer a changed font colour) - will see what ajax will do.
  3. Add the unread_count to the string, i.e. [ 3 Notifications ]. This might not be such a good idea considering messages has a count so probably too much for the loaction.

Nice work.

User avatar
Vinny
Style Customisations
Style Customisations
Posts: 129
Joined: Thu May 20, 2010 4:01 am
Location: Brazil
Contact:

Re: [RFC] notification box

Post by Vinny » Sun Sep 16, 2012 4:25 pm

+1 for oddfish.

User avatar
oddfish
Registered User
Posts: 110
Joined: Tue Mar 27, 2007 5:53 am
Location: on my way home
Contact:

Re: [RFC] notification box

Post by oddfish » Wed Sep 19, 2012 9:42 am

A few quirks ..
  • Separation needed between notifications (eg, horizontal line or bg2 bg1 but not sure what ajax will do).
  • Notifications for bookmarked topics show time of Thu Jan 1st, 1970, 12:00pm - this changes to the correct board time when edited (i.e. a post). PM notifications show correctly.
  • If a post is edited, the username loses its group colour assigned in the notification.

User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: [RFC] notification box

Post by EXreaction » Wed Sep 19, 2012 4:45 pm

Thanks for all the hard work testing it, I will look into those issues.

Post Reply