[RFC] Multiple file uploads

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
Post Reply
User avatar
Fyorl
Google Summer of Code Student
Posts: 27
Joined: Mon Apr 02, 2012 4:51 am
Location: UK
Contact:

Re: [RFC] Multiple file uploads

Post by Fyorl » Sat Jun 16, 2012 6:16 pm

I've currently written code to have the client use alert() when the server responds with an error in the middle of uploading one of the files. This effectively pauses the uploads until the user clicks ok. Is this desired behaviour? I feel it might be preferable to have the icon next to the file indicate that there was a problem but let the upload continue (example attached). The problem with this method is that the error message is lost though I might be able to add some more code to have it appear in tooltip of the warning icon or something.
Attachments
plupload-error-example.png
plupload-error-example.png (3.71 KiB) Viewed 6203 times

User avatar
naderman
Product Manager
Product Manager
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC] Multiple file uploads

Post by naderman » Sun Jun 17, 2012 1:15 pm

I would prefer the icon solution. However the error message should be made available through a click on the icon. Having it as the tooltip would be useful as well, but I would rather add both than just one of these methods.

User avatar
Fyorl
Google Summer of Code Student
Posts: 27
Joined: Mon Apr 02, 2012 4:51 am
Location: UK
Contact:

Re: [RFC] Multiple file uploads

Post by Fyorl » Sun Jun 17, 2012 7:45 pm

Sounds good to me.

User avatar
brunoais
Registered User
Posts: 958
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC] Multiple file uploads

Post by brunoais » Mon Jun 18, 2012 6:47 am

^
Me too.
I don't like relying on alert() or one of the other 3 internal js popups to stop some js code. The alert() is meant to alert the user, so it does make sense to alert if an upload goes wrong and then, if the user wants more info, just click the exclamation mark.

User avatar
Fyorl
Google Summer of Code Student
Posts: 27
Joined: Mon Apr 02, 2012 4:51 am
Location: UK
Contact:

Re: [RFC] Multiple file uploads

Post by Fyorl » Mon Jun 18, 2012 3:43 pm

Plupload is fully integrated now as far as I can tell. Any feedback on additional features is welcome; the PR can be found here: https://github.com/phpbb/phpbb3/pull/833

Once any new features are added I'll try to write some tests and then move on to the 'download all files in this post' and 'download all files in this topic' features.

Danielx64
Registered User
Posts: 304
Joined: Mon Feb 08, 2010 3:42 am

Re: [RFC] Multiple file uploads

Post by Danielx64 » Thu Jul 05, 2012 4:50 am

I know I asked this else where, is there away to get this going on phpbb 3.0 or not?

User avatar
naderman
Product Manager
Product Manager
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC] Multiple file uploads

Post by naderman » Thu Jul 05, 2012 3:42 pm

This will not be added to 3.0. Whether or not someone wants to make a MOD like this, I don't know.

Danielx64
Registered User
Posts: 304
Joined: Mon Feb 08, 2010 3:42 am

Re: [RFC] Multiple file uploads

Post by Danielx64 » Fri Jul 06, 2012 4:52 am

Thats a shame, other question, can dyou download a diff file from git? or not?

User avatar
Fyorl
Google Summer of Code Student
Posts: 27
Joined: Mon Apr 02, 2012 4:51 am
Location: UK
Contact:

Re: [RFC] Multiple file uploads

Post by Fyorl » Fri Jul 06, 2012 10:19 pm

*Daniel wrote:Thats a shame, other question, can dyou download a diff file from git? or not?
You should be able to use git to pull anyone's branch into your local repo.

User avatar
psoTFX
Registered User
Posts: 1984
Joined: Tue Jul 03, 2001 8:50 pm
Contact:

Re: [RFC] Multiple file uploads

Post by psoTFX » Fri Jul 06, 2012 10:26 pm

If you want a patch or diff for a given pull request just add .patch or .diff to the PR no. in the url, e.g. https://github.com/phpbb/phpbb3/pull/877.patch

Post Reply