[RFC|Merged] Copy post text in report when reporting posts

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
User avatar
brunoais
Registered User
Posts: 958
Joined: Fri Dec 18, 2009 3:55 pm

[RFC|Merged] Copy post text in report when reporting posts

Post by brunoais » Thu Jan 19, 2012 8:59 pm

Introduction
In phpBB, when there's a report for a post made in the BB, phpBB only saves the postID in the database. If the post itself is changed, there's no way of knowing what was there before that caused the user to make the report.

Proposal
- When a report is made for a post, make a copy of the post itself and join it with the report.
-The post that appears above "Return to the reports | View post | View topic | View forum" in the Report details page will have that text instead of the current text.
- Where the context of the post is available, it's possible to make a mark around the reported post (a red border, perhaps....) and show as it is now with the other current posts.

How to do it
When a report is made, among the rest of the data that is saved in the table, the body of the post is also saved in the report table row not just the id of the post.

Pros
  • If the post is changed after the report, the moderators will be able to know what was there before and take action accordingly.
  • If there's a need to keep record of the reason of all reports and that content should disappear from the public eye (copyright material, as an example) with this feature that is now possible.
Cons
  • Of course, duplicate data means more space used for the same purpose, but it's for a good cause.
UPDATE
Tracker issue:
http://tracker.phpbb.com/browse/PHPBB3-10600

Edit:
Pull request:
https://github.com/phpbb/phpbb3/pull/542

ADD:
All set. Seems like the code is ready to be reviewed. Waiting for the answer

Finally:
Merge is confirmed.
Last edited by brunoais on Wed Mar 28, 2012 7:07 pm, edited 4 times in total.

User avatar
callumacrae
Infrastructure Team
Infrastructure Team
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [RFC]When creating a report for a post, copy the post it

Post by callumacrae » Thu Jan 19, 2012 9:56 pm

+1!
Made by developers, for developers!
My blog

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC]When creating a report for a post, copy the post it

Post by imkingdavid » Fri Jan 20, 2012 2:57 am

That's a great point.

As it is now, a user could break the rules on purpose when he sees no active moderators online, and then edit the post.

Alternatively (or cooperatively) we could prevent editing the post once it has been reported. *shrug*

Note that I remember seeing a Post History/Revisions discussion. If something like that was implemented, this wouldn't be as big of an issue, but we would then still need to identify which issue was reported so that if the post is modified after the report is filed they can track down the offense. But that's not applicable at the moment, I suppose.

Anyway, I'm for it.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
MichaelC
Development Team
Development Team
Posts: 889
Joined: Thu Jan 28, 2010 6:29 pm

Re: [RFC]When creating a report for a post, copy the post it

Post by MichaelC » Fri Jan 20, 2012 4:44 pm

I believe phpBB has a lock post editing which could be enabled upon a report being made?
Formerly known as Unknown Bliss
psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
No unsolicited PMs please except for quotes.

User avatar
brunoais
Registered User
Posts: 958
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC]When creating a report for a post, copy the post it

Post by brunoais » Fri Jan 20, 2012 6:28 pm

Unknown Bliss wrote:I believe phpBB has a lock post editing which could be enabled upon a report being made?
It has, actually. But, usually, when something is violating a rule, what you want to do is to alter that post so that it becomes ok, still, you want to have the original one.
That is an option that does not fix this problem completely.

User avatar
MichaelC
Development Team
Development Team
Posts: 889
Joined: Thu Jan 28, 2010 6:29 pm

Re: [RFC]When creating a report for a post, copy the post it

Post by MichaelC » Sat Jan 21, 2012 2:24 pm

Moderators can unlock the post for editing and edit the post?
Formerly known as Unknown Bliss
psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
No unsolicited PMs please except for quotes.

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1731
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [RFC]When creating a report for a post, copy the post it

Post by DavidIQ » Sat Jan 21, 2012 4:03 pm

Unknown Bliss wrote:Moderators can unlock the post for editing and edit the post?
I think the issue really is that after you edit the post the whole reason for the infraction is lost unless you copy the entire post into your note. "Warning for foul language" doesn't have as much weight in the event of a ban unless you actually track what it is that won the person the warning in the first place.

However that is not what is being discussed. I sort of agree with UB here. Lock the post when there is a report created. Also locking a post does not prevent a moderator from actually editing the post. ;)
Image

User avatar
brunoais
Registered User
Posts: 958
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC]When creating a report for a post, copy the post it

Post by brunoais » Sat Jan 21, 2012 4:51 pm

I still believe that losing the original post that created a report is bad. The same applies to losing the original post.
Think like this:
User posts the unallowed post.
User reports the post.
moderator (without seeing the report for some reason. Happens sometimes) edits the post.
(note: the report is still active)
Other moderator checks that the report is active
How to solve now? Is the reporter blamed for wrong report (doesn't seem so, the mods know the post has been edited). The moderator for doing he's job even though he lost all the evidence of what he has done?

If you accept, I may prepare the code to do these jobs for you to add it yourselves. Just need a little research and it's not that complicated.

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC]When creating a report for a post, copy the post it

Post by imkingdavid » Sat Jan 21, 2012 7:58 pm

brunoais wrote:If you accept, I may prepare the code to do these jobs for you to add it yourselves. Just need a little research and it's not that complicated.
You are more than welcome to prepare a patch of this feature if you would like to. First, please create a ticket on the tracker so we can keep track of it. You would need to use Git to checkout the latest revision on the develop branch and use these wiki articles (here and here) if you need some info on how to continue.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
brunoais
Registered User
Posts: 958
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC]When creating a report for a post, copy the post it

Post by brunoais » Sat Jan 21, 2012 8:09 pm

imkingdavid wrote:
brunoais wrote:If you accept, I may prepare the code to do these jobs for you to add it yourselves. Just need a little research and it's not that complicated.
You are more than welcome to prepare a patch of this feature if you would like to. First, please create a ticket on the tracker so we can keep track of it. You would need to use Git to checkout the latest revision on the develop branch and use these wiki articles (here and here) if you need some info on how to continue.
k, I'll read that. After that I'll read the git instructions and then I'll create the ticket and start coding the patch.

Post Reply