[RFC|Merged] Rounded corners via css

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
wGEric
Registered User
Posts: 521
Joined: Wed Jun 11, 2003 2:07 am
Contact:

Re: [RFC] Rounded corners via css

Post by wGEric » Thu Jan 19, 2012 9:14 pm

Make sure you look at the known issues for pie. There is one about serving the correct content type that will affect how it needs to be implemented. To make sure it actually works on every server you will probably have to use the php method.
Eric

User avatar
Arty
Registered User
Posts: 970
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: [RFC] Rounded corners via css

Post by Arty » Thu Jan 19, 2012 9:19 pm

TheKiller wrote:But maybe you should do the fallowing:
If Google Chrome Frame is not installed, you can direct your users to an installation page.
That is a bad idea. Forum should work for users, not force them to install some addons. Such approach will only annoy users, causing them to switch to other forum solutions.
wGEric wrote:Make sure you look at the known issues for pie. There is one about serving the correct content type that will affect how it needs to be implemented. To make sure it actually works on every server you will probably have to use the php method.
That's bad :(
Thanks for finding it.
Formerly known as CyberAlien.

Free phpBB styles | Premium responsive XenForo styles

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Rounded corners via css

Post by imkingdavid » Fri Jan 20, 2012 2:58 am

Arty wrote:
TheKiller wrote:But maybe you should do the fallowing:
If Google Chrome Frame is not installed, you can direct your users to an installation page.
That is a bad idea. Forum should work for users, not force them to install some addons. Such approach will only annoy users, causing them to switch to other forum solutions,
+1 phpBB should work out of the box without requiring users to go install even more things. Of course, depending on their browser that may mean a less than optimal browsing experience (although with IE, that's to be expected :lol:), but that's neither our fault nor our problem. We do what we can to make the experience as similar across browsers as possible, understanding that some browsers don't play as nicely as others. Major features should definitely take such things into account, even to the point of leaving them out if not all users will be able to use them, but something like rounded corners isn't a major feature. Besides, pointy corners aren't all bad, and the page load will decrease because the image won't have to be loaded each time.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
Ger
Registered User
Posts: 270
Joined: Mon Jul 26, 2010 1:55 pm
Location: 192.168.1.100
Contact:

Re: [RFC] Rounded corners via css

Post by Ger » Fri Jan 20, 2012 12:08 pm

imkingdavid wrote:+1 phpBB should work out of the box without requiring users to go install even more things. Of course, depending on their browser that may mean a less than optimal browsing experience (although with IE, that's to be expected :lol:), but that's neither our fault nor our problem. We do what we can to make the experience as similar across browsers as possible, understanding that some browsers don't play as nicely as others. Major features should definitely take such things into account, even to the point of leaving them out if not all users will be able to use them, but something like rounded corners isn't a major feature. Besides, pointy corners aren't all bad, and the page load will decrease because the image won't have to be loaded each time.
+1.
Above message may contain errors in grammar, spelling or wrongly chosen words. This is because I'm not a native speaker. My apologies in advance.

User avatar
callumacrae
Infrastructure Team
Infrastructure Team
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [RFC] Rounded corners via css

Post by callumacrae » Fri Jan 20, 2012 5:06 pm

TheKiller wrote:But maybe you should do the fallowing:
If Google Chrome Frame is not installed, you can direct your users to an installation page.
That isn't phpBB's place to do, I would strongly disagree with it.

naderman wrote: I'd rather skip any IE specific workarounds like PIE, and just go with the CSS3 solution. Not having rounded corners is really not the end of the world.
+1
Made by developers, for developers!
My blog

User avatar
Dragosvr92
Registered User
Posts: 624
Joined: Tue May 31, 2011 12:08 pm
Location: Romania
Contact:

Re: [RFC] Rounded corners via css

Post by Dragosvr92 » Fri Jan 20, 2012 7:17 pm

Well i say to just get on with the CSS3 propertys and ignore IE, Like Naderman said.
Its okay if they dont see round corners, not really a big issue. If they want performance they should upgrade their browsers, same like with operating systems. I guess the PIE Option could be made into a MODification and the forum owners can add it if they feel like it. The MOD Could have a module that enables the PIE Addon and a warning message to upgrade to a modern browser, or at least IE9. Or... add two options for PiE And Google Chromes frame..... Theres too many ifs.. i sort of get confused in writing :roll:
Previous user: TheKiller
Avatar on Memberlist 1.0.3

User avatar
hanakin
Infrastructure Team
Infrastructure Team
Posts: 790
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: [RFC] Rounded corners via css

Post by hanakin » Sat Jan 21, 2012 1:45 am

seeing as how i first proposed it obviously +1 lol :D also something to consider al be it not related to round corners but if we do away with all the gradients on the forums and the header and change the color scheme we can also eliminate the need for alot of the image overhead as well making the theme load faster more along the lines of subsilver, coupled with the dynamic sprite concept that was in the works if it ever gets implemented will completely streamline the theme. Only thing left from their as far as theme improvements go from the original topic is the HTML/CSS restructure into a cleaner and more semantic file. but really need to completely externalize the JS before that can/should happen

User avatar
Arty
Registered User
Posts: 970
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: [RFC] Rounded corners via css

Post by Arty » Thu Mar 29, 2012 9:27 pm

Updated first post, created ticket.
Formerly known as CyberAlien.

Free phpBB styles | Premium responsive XenForo styles

User avatar
Arty
Registered User
Posts: 970
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: [RFC|Merged] Rounded corners via css

Post by Arty » Tue Apr 10, 2012 7:59 pm

This RFC was solved by Shibu Lijack and merged.

PR: https://github.com/phpbb/phpbb3/pull/674
Formerly known as CyberAlien.

Free phpBB styles | Premium responsive XenForo styles

User avatar
Vinny
Style Customisations
Style Customisations
Posts: 126
Joined: Thu May 20, 2010 4:01 am
Location: Brazil
Contact:

Re: [RFC|Merged] Rounded corners via css

Post by Vinny » Sun May 06, 2012 4:01 pm

border-radius should be applied to docs/stylesheet.css too.

igorw wrote:As per IRC, images/corners_left.png and images/corners_right.png can be removed. @cyberalien mentioned that having to add that clear class everywhere is not so nice.
Any reason to keep the images corners_left2.gif and corners_right2.gif?

Post Reply