[RFC|Merged] Merge style components

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: [RFC] Merge style components

Post by Oleg » Wed Mar 14, 2012 7:05 am

Arty wrote:
Oleg wrote:What is the purpose of bbcode bit field?
I'm not sure about that. It is used by bbcode.php for something
Removal of bbcode bit field should be a separate RFC + PR and it should be approved by someone who does know and understand its purpose.

Merging of style components sounds good to me but it needs to be extricated out of 577 into its own PR for me to look at it.

Some of viewtopic.php?f=108&t=42439 will I'm assuming need to be included into the PR merging style components. Anything in viewtopic.php?f=108&t=42439 not dealing with merging of style components should be a separate PR.

User avatar
Arty
Registered User
Posts: 970
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: [RFC] Merge style components

Post by Arty » Wed Mar 14, 2012 5:05 pm

I agree with bbcode bit field, I'll keep it for now, but it will be moved to styles table because template table won't exist any more.

I'll try to keep pull request to bare minimum, it will include only functions needed to make things work: merging components, styles tree, basic functionality in acp_styles (install/uninstall, active/deactivate, style details).

Things that won't make it into pull request:
- bbcode bit field
- editing templates via acp
- locator functions
- cleaning up acp_styles language file (removing unused entries - I'll remove few entries that refer to components that no longer exist, but not all of them)
Formerly known as CyberAlien.

Free phpBB styles | Premium responsive XenForo styles

User avatar
Arty
Registered User
Posts: 970
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: [RFC] Merge style components

Post by Arty » Thu Mar 15, 2012 2:37 pm

Old pull request closed, new development is in this branch: https://github.com/cyberalien/phpbb3/co ... components

It isn't finished yet, but current tree should be working. All current commits, except for new acp_styles.php, will be the same in pull request, so those commits can be validated. Don't mind old text in docblocks, I haven't started working on that yet.
Formerly known as CyberAlien.

Free phpBB styles | Premium responsive XenForo styles

User avatar
Arty
Registered User
Posts: 970
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: [RFC] Merge style components

Post by Arty » Thu Mar 15, 2012 7:23 pm

Patch is available: https://github.com/phpbb/phpbb3/pull/625

Code included in patch:
- Merging style components.
- Unlimited styles tree.
- New style superclass. Now there are 2 global variables: $style and $template instead of only $template.
- New acp_styles. It includes only basic styles management functions to make patch smaller. Other functions, such as template editing in acp, will have its own RFCs.
Formerly known as CyberAlien.

Free phpBB styles | Premium responsive XenForo styles

User avatar
igorw
Registered User
Posts: 500
Joined: Thu Jan 04, 2007 11:47 pm

Re: [RFC] Merge style components

Post by igorw » Sat Mar 31, 2012 3:31 pm

Merged.

Michaelo
Registered User
Posts: 106
Joined: Thu Apr 01, 2004 7:56 am
Location: Dublin

Re: [RFC|Merged] Merge style components

Post by Michaelo » Wed Aug 29, 2012 3:03 pm

+1
Enough said...
Mods: Forum Icons Enhancement, Kiss Portal Engine
Links:
Kiss Portal Engine (dev site) Stargate Portal (archive site) ...
Styles: Technika

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC|Merged] Merge style components

Post by imkingdavid » Wed Aug 29, 2012 3:09 pm

This was already merged and does not require further input.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

Michaelo
Registered User
Posts: 106
Joined: Thu Apr 01, 2004 7:56 am
Location: Dublin

Re: [RFC|Merged] Merge style components

Post by Michaelo » Fri Aug 31, 2012 2:42 am

Actually I had added a comment relating to naderman post re inheritance, but realising the RFC had already been merged, and as I could not delete my post, I simply added +1
Mods: Forum Icons Enhancement, Kiss Portal Engine
Links:
Kiss Portal Engine (dev site) Stargate Portal (archive site) ...
Styles: Technika

Post Reply