[RFC] Override Language via URL

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1731
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [RFC] Override Language via URL

Post by DavidIQ » Fri Mar 20, 2015 7:55 pm

VSE wrote:A logged in user can select a language in preferences. Visitors can not, which is why this only works for visitors. And this was not a casual choice, there were also many issues trying to get it to work for everybody, and it's not worth all the trouble it was, so the current implementation was decided to be the best trade off.
That's kind of strange because the original request and beginning of this RFC was specifically geared towards guest users:
imkingdavid wrote:This topic requested that users be able to add lang=xx to the URL query string in order to override the board's language for users who are unregistered and do not know enough of the default language or the forum layout to create an account.

This shouldn't be too big of a change, simply check the URL to see if $_GET['lang'] is present and whether or not the chosen language is available for use, and if so, override the board's default language.

EDIT: See Ticket
Also seems kind of useless to only have this for registered users. They would already have their language determined in their account settings. So either this was implemented incorrectly or this was not implemented at all. Devs?
Image

User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 670
Joined: Mon Mar 08, 2010 9:18 am

Re: [RFC] Override Language via URL

Post by VSE » Sat Mar 21, 2015 1:28 am

DavidIQ wrote:
VSE wrote:A logged in user can select a language in preferences. Visitors can not, which is why this only works for visitors. And this was not a casual choice, there were also many issues trying to get it to work for everybody, and it's not worth all the trouble it was, so the current implementation was decided to be the best trade off.
That's kind of strange because the original request and beginning of this RFC was specifically geared towards guest users:
Strange how? We did what the original request of this RFC asked. Only guests can override the lang via URL param.

We tried to make it available for all users, but it just wasn't working for reg. users. But for guests it works via the url (and persists via cookies).
Has an irascible disposition.

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1731
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [RFC] Override Language via URL

Post by DavidIQ » Sat Mar 21, 2015 2:58 am

Ok I understand what you wrote now. Got it backwards.
Image

raykai
Registered User
Posts: 3
Joined: Wed Feb 24, 2016 6:56 pm

Re: [RFC] Override Language via URL

Post by raykai » Sun Sep 11, 2016 4:27 am

it seams as this has bin flagged as fix but its not at least not in 3.1.9.... https://tracker.phpbb.com/browse/PHPBB3-10521#

im also in need of a way to change the language using the url.

User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 670
Joined: Mon Mar 08, 2010 9:18 am

Re: [RFC] Override Language via URL

Post by VSE » Sun Sep 11, 2016 8:14 am

It works...Only for guests obviously. ?language=xx
Has an irascible disposition.

Post Reply