[RFC|Merged] Use Google's jQuery

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
Post Reply
Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: [RFC] Use Google's jQuery

Post by Oleg » Tue Oct 18, 2011 6:28 am

/a3 wrote:On privacy regarding Google CDN:

Just as a note, after a bit of searching I found that Google's CDN does not use cookies. The only things that it could see are referer headers and the IP addresses of the clients themselves.
Google sets cookies on .google.com. Google ajax apis recommends using their loader for loading the libraries, which lives on http://www.google.com.

A more reasonable position than "google does not use cookies! party!" would be "it so happens that right now google is tracking you via means other than cookies".

User avatar
/a3
Registered User
Posts: 97
Joined: Mon Sep 20, 2010 6:44 am

Re: [RFC] Use Google's jQuery

Post by /a3 » Tue Oct 18, 2011 8:24 am

But will phpBB be using the loader? That is not something that comes in standard with jQuery, and if plain jQuery is being provided I don't see why their API would be needed.

I've checked online, and it appears that the loader exists for performance, and so that theoretically any JavaScript library can be loaded using their loader. That's not really a requirement here, I don't believe. I do understand what you're saying, but in this case using their CDN for plain jQuery shouldn't lead to any problems with cookies.

User avatar
naderman
Product Manager
Product Manager
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC] Use Google's jQuery

Post by naderman » Wed Oct 19, 2011 1:23 pm

/a3 wrote:I do understand what you're saying, but in this case using their CDN for plain jQuery shouldn't lead to any problems with cookies.
I don't think you do. Any HTTP request to *.google.com will transmit google cookie information and any such response can set cookies, no matter how it's made.

wGEric
Registered User
Posts: 521
Joined: Wed Jun 11, 2003 2:07 am
Contact:

Re: [RFC] Use Google's jQuery

Post by wGEric » Wed Oct 19, 2011 11:37 pm

naderman wrote:I don't think you do. Any HTTP request to *.google.com will transmit google cookie information and any such response can set cookies, no matter how it's made.
The domain for the CDN is ajax.googleapis.com and not google.com. It appears that no cookies get set on .googleapis.com.

https://ajax.googleapis.com/ajax/libs/j ... ery.min.js
https://ajax.googleapis.com/ajax/libs/j ... /jquery.js
Eric

User avatar
/a3
Registered User
Posts: 97
Joined: Mon Sep 20, 2010 6:44 am

Re: [RFC] Use Google's jQuery

Post by /a3 » Thu Oct 20, 2011 7:14 am

wGEric wrote:
naderman wrote:I don't think you do. Any HTTP request to *.google.com will transmit google cookie information and any such response can set cookies, no matter how it's made.
The domain for the CDN is ajax.googleapis.com and not google.com. It appears that no cookies get set on .googleapis.com.

https://ajax.googleapis.com/ajax/libs/j ... ery.min.js
https://ajax.googleapis.com/ajax/libs/j ... /jquery.js
Yes, that's what I meant, apologies for any confusion.

I've checked on a few friends computers (who never clear their cookies) and they didn't have any cookies from either ajax.googleapis.com or googleapis.com. Also checking the HTTP headers of those files confirms that those files alone don't set cookies (although if they were previously set they would be sent).

User avatar
callumacrae
Infrastructure Team
Infrastructure Team
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [RFC] Use Google's jQuery

Post by callumacrae » Thu Oct 20, 2011 3:24 pm

http://googlegeodevelopers.blogspot.com ... -news.html

"Services on googleapis.com are guaranteed to never set cookies, nor do they ever receive google.com cookies."
Made by developers, for developers!
My blog

User avatar
naim
Registered User
Posts: 50
Joined: Thu Oct 13, 2011 7:21 pm
Location: Isolation
Contact:

Re: [RFC] Use Google's jQuery

Post by naim » Thu Oct 20, 2011 4:32 pm

About privacy, (The whole "should we use google's jQuery...). Google probably doesn't set cookies on the clients browser...
but like already said, they can track you in other ways... (The client must connect to their server...)

What about letting the admin to add custom CDNs and by default add all the main ones and a choice to use the one that comes with phpBB, and then let the user choose from a list of CDNs on UCP...

User avatar
callumacrae
Infrastructure Team
Infrastructure Team
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [RFC] Use Google's jQuery

Post by callumacrae » Thu Oct 20, 2011 5:50 pm

naim wrote:About privacy, (The whole "should we use google's jQuery...). Google probably doesn't set cookies on the clients browser...
callumacrae wrote:http://googlegeodevelopers.blogspot.com ... -news.html

"Services on googleapis.com are guaranteed to never set cookies, nor do they ever receive google.com cookies."
naim wrote:but like already said, they can track you in other ways... (The client must connect to their server...)
naim wrote:already said
naim wrote:What about letting the admin to add custom CDNs and by default add all the main ones and a choice to use the one that comes with phpBB, and then let the user choose from a list of CDNs on UCP...
Already discussed and decided:
VSE+ wrote:I will bring this down to a single Yes/No option using the Google CDN then.


naderman wrote:That's exactly what the goal now is, please read the topic before you reply.

Please read the previous posts, we discussed this quite a bit.
Made by developers, for developers!
My blog

User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 670
Joined: Mon Mar 08, 2010 9:18 am

Re: [RFC] Use Google's jQuery

Post by VSE » Thu Oct 20, 2011 8:09 pm

Despite all this tangential discussion, the patch is finished, as far as I'm concerned, and is just sitting up there at Github awaiting action from the Dev team gurus. :)
Has an irascible disposition.

Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: [RFC|Merged] Use Google's jQuery

Post by Oleg » Fri Oct 21, 2011 12:47 am

Merged.

Post Reply