[RFC|Merged] Removal of imagesets

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
Post Reply
User avatar
Arty
Registered User
Posts: 970
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: [RFC|Merged] Removal of imagesets

Post by Arty » Sat Feb 18, 2012 10:23 pm

What do you mean?
Formerly known as CyberAlien.

Free phpBB styles | Premium responsive XenForo styles

User avatar
nextgen
Registered User
Posts: 128
Joined: Sat Jul 24, 2010 4:59 am
Location: Guatemala
Contact:

Re: [RFC|Merged] Removal of imagesets

Post by nextgen » Sat Feb 18, 2012 10:24 pm

Arty wrote:What do you mean?
This?
nextgen wrote:the css classes at the stylesheet root/styles/prosilver/theme/en/stylesheet.css are wrong :
This :
.imageset.button_topic_new {
Should ber :
.post-icon span {

because there are no call to any class named .imageset or .button_topic_new in the template, if you duplicate the file root/styles/prosilver/theme/en/stylesheet.css to another language and put your images inside that folder are never used, at least for big buttons and post buttons in prosilver style.

This is a fixed example for Spanish (es) language.

Code: Select all

/* Set big button dimensions */
.buttons div.reply-icon		{ width: 96px; height: 25px; }
.buttons div.post-icon		{ width: 96px; height: 25px; }
.buttons div.locked-icon	{ width: 88px; height: 25px; }
.buttons div.pmreply-icon	{ width: 96px; height: 25px; }
.buttons div.newpm-icon		{ width: 84px; height: 25px; }
.buttons div.forwardpm-icon	{ width: 96px; height: 25px; }

/* Set profile icon dimensions */
ul.profile-icons li.pm-icon		{ width: 28px; height: 20px; }
ul.profile-icons li.quote-icon	{ width: 54px; height: 20px; }
ul.profile-icons li.edit-icon	{ width: 42px; height: 20px; }

 /* ES Language Pack */
.pm-icon, .pm-icon a {
    background-image: url("./icon_contact_pm.gif");
}
.edit-icon, .edit-icon a {
	background-image: url("./icon_post_edit.gif");
}
.quote-icon, .quote-icon a {
	background-image: url("./icon_post_quote.gif");
}
.forwardpm-icon span {
    background-image: url("./button_pm_forward.gif");
}
.newpm-icon span {
    background-image: url("./button_pm_new.gif");
}
.pmreply-icon span {
    background-image: url("./button_pm_reply.gif");
}
.online {
    background-image: url("./icon_user_online.gif");
}
.locked-icon span {
    background-image: url("./button_topic_locked.gif");
}
.post-icon span {
	background-image: url("./button_topic_new.gif");
}
.reply-icon span {
	background-image: url("./button_topic_reply.gif");
}
*Imagine a signature super spectacular.*

User avatar
Arty
Registered User
Posts: 970
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: [RFC|Merged] Removal of imagesets

Post by Arty » Sat Feb 18, 2012 10:31 pm

You have outdated stylesheet.css. Look in recent develop branch.
Formerly known as CyberAlien.

Free phpBB styles | Premium responsive XenForo styles

User avatar
nextgen
Registered User
Posts: 128
Joined: Sat Jul 24, 2010 4:59 am
Location: Guatemala
Contact:

Re: [RFC|Merged] Removal of imagesets

Post by nextgen » Sat Feb 18, 2012 10:40 pm

Arty wrote:You have outdated stylesheet.css. Look in recent develop branch.
sure?
I got it for your profile on github
https://github.com/phpbb/phpbb3/blob/57 ... esheet.css
*Imagine a signature super spectacular.*

User avatar
Arty
Registered User
Posts: 970
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: [RFC|Merged] Removal of imagesets

Post by Arty » Sat Feb 18, 2012 11:15 pm

That's wrong URL. It points to old commit, not to latest version.
Here is correct URL: https://github.com/phpbb/phpbb3/blob/de ... esheet.css
Formerly known as CyberAlien.

Free phpBB styles | Premium responsive XenForo styles

User avatar
nextgen
Registered User
Posts: 128
Joined: Sat Jul 24, 2010 4:59 am
Location: Guatemala
Contact:

Re: [RFC|Merged] Removal of imagesets

Post by nextgen » Sat Feb 18, 2012 11:24 pm

I said nothing then :)

PD: I guess for another language is not the same file?
*Imagine a signature super spectacular.*

User avatar
Arty
Registered User
Posts: 970
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: [RFC|Merged] Removal of imagesets

Post by Arty » Sat Feb 18, 2012 11:29 pm

File is the same, directory is different.
Formerly known as CyberAlien.

Free phpBB styles | Premium responsive XenForo styles

User avatar
nextgen
Registered User
Posts: 128
Joined: Sat Jul 24, 2010 4:59 am
Location: Guatemala
Contact:

Re: [RFC|Merged] Removal of imagesets

Post by nextgen » Sat Feb 18, 2012 11:32 pm

Arty wrote:File is the same, directory is different.
It solved most of my doubts as to change the imageset
so glad to collaborate with the project :)
*Imagine a signature super spectacular.*

User avatar
oddfish
Registered User
Posts: 110
Joined: Tue Mar 27, 2007 5:53 am
Location: on my way home
Contact:

Re: [RFC|Merged] Removal of imagesets

Post by oddfish » Sat Feb 18, 2012 11:35 pm

Arty wrote:Take a look at very common situation: user has installed his language pack, but style does not have imageset for it.

In 3.0: edit, quote and other language specific images disappear
In 3.1: edit, quote and other language specific images fall back to English

That's why that change is there.
Appreciate that and I see this reason.
My issue is having different values to doing the same job. I thought the idea was to simplify and clean up the prosilver css, not to confuse it further by creating differences. That said, I should look closer at the template system calling the language images. Surely it can be simpler.

User avatar
Arty
Registered User
Posts: 970
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: [RFC|Merged] Removal of imagesets

Post by Arty » Sat Feb 18, 2012 11:39 pm

If some entries are the same, you can remove them from your custom language pack.
Formerly known as CyberAlien.

Free phpBB styles | Premium responsive XenForo styles

Post Reply