[RFC|Merged] Removal of imagesets

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
Post Reply
User avatar
Arty
Registered User
Posts: 970
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: [RFC|Merged] Removal of imagesets

Post by Arty » Thu Oct 13, 2011 6:55 pm

What for? All language specific css should be in theme/{lang}/stylesheet.css, so you don't need it
Formerly known as CyberAlien.

Free phpBB styles | Premium responsive XenForo styles

Dakin Quelia
Registered User
Posts: 11
Joined: Mon Feb 02, 2009 4:44 pm

Re: [RFC|Merged] Removal of imagesets

Post by Dakin Quelia » Thu Oct 13, 2011 7:11 pm

It is interesting to include the variables, which define the paths and which allow not to modify each path but with a general varibable, it would be easier to update all these paths. ;)

User avatar
Arty
Registered User
Posts: 970
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: [RFC|Merged] Removal of imagesets

Post by Arty » Thu Oct 13, 2011 7:24 pm

But why? What do you need to include?
Formerly known as CyberAlien.

Free phpBB styles | Premium responsive XenForo styles

Dakin Quelia
Registered User
Posts: 11
Joined: Mon Feb 02, 2009 4:44 pm

Re: [RFC|Merged] Removal of imagesets

Post by Dakin Quelia » Thu Oct 13, 2011 7:32 pm

It's easier to modify a single path (via {T_THEME_PATH} or {T_THEME_LANG_PATH}) in php file rather than modify each CSS file to fix the image path (lang or not)... ? ;)

User avatar
Arty
Registered User
Posts: 970
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: [RFC|Merged] Removal of imagesets

Post by Arty » Thu Oct 13, 2011 7:35 pm

What path? There is only one path for images: ./images/, that's all. In language specific css file its ./

I think you don't know how urls in css files work. They are relative to css file, NOT to document. So its not styles/prosilver/theme/images/whatever.png, but images/whatever.png
Formerly known as CyberAlien.

Free phpBB styles | Premium responsive XenForo styles

leviatan21
Registered User
Posts: 18
Joined: Tue May 05, 2009 5:51 pm

Re: [RFC|Merged] Removal of imagesets

Post by leviatan21 » Thu Oct 13, 2011 7:56 pm

What about New template variables
Use much less css instead duplicated code for different languages :roll:
QA Team Member - I don't support by PM,
Customize forums, install Skins/Mods ! Sendme a PM | Don't forget to visit my other mods
Excuse me for my poor English, I speak Spanish. | Image phpBB en Español

User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: [RFC|Merged] Removal of imagesets

Post by nickvergessen » Fri Oct 14, 2011 12:40 pm

leviatan21 wrote:What about New template variables
Use much less css instead duplicated code for different languages :roll:
the only thing that is duplicated for different languages are the language strings themselves :?
Member of the Development-TeamNo Support via PM

User avatar
canonknipser
Registered User
Posts: 59
Joined: Mon Sep 19, 2011 4:42 am
Location: Germany

Re: [RFC|Merged] Removal of imagesets

Post by canonknipser » Fri Oct 14, 2011 5:15 pm

nickvergessen wrote:
leviatan21 wrote:What about New template variables
Use much less css instead duplicated code for different languages :roll:
the only thing that is duplicated for different languages are the language strings themselves :?
Maybe not - some languages are very similar, so you can think about "inherited" languages, eg. "en" -> "en-us" or "de" -> "de-at", because in those "dialects" only a few words differ from the basic language
Greetings, Frank

english is not my native language

User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: [RFC|Merged] Removal of imagesets

Post by nickvergessen » Fri Oct 21, 2011 12:42 pm

Just what I said?! You don't need any images more from now on, you can just change your css file and make it point to the original images?
Member of the Development-TeamNo Support via PM

User avatar
nextgen
Registered User
Posts: 128
Joined: Sat Jul 24, 2010 4:59 am
Location: Guatemala
Contact:

Re: [RFC|Merged] Removal of imagesets

Post by nextgen » Tue Dec 27, 2011 11:36 pm

the css classes at the stylesheet root/styles/prosilver/theme/en/stylesheet.css are wrong :
This :
.imageset.button_topic_new {
Should ber :
.post-icon span {

because there are no call to any class named .imageset or .button_topic_new in the template, if you duplicate the file root/styles/prosilver/theme/en/stylesheet.css to another language and put your images inside that folder are never used, at least for big buttons and post buttons in prosilver style.

This is a fixed example for Spanish (es) language.

Code: Select all

/* Set big button dimensions */
.buttons div.reply-icon		{ width: 96px; height: 25px; }
.buttons div.post-icon		{ width: 96px; height: 25px; }
.buttons div.locked-icon	{ width: 88px; height: 25px; }
.buttons div.pmreply-icon	{ width: 96px; height: 25px; }
.buttons div.newpm-icon		{ width: 84px; height: 25px; }
.buttons div.forwardpm-icon	{ width: 96px; height: 25px; }

/* Set profile icon dimensions */
ul.profile-icons li.pm-icon		{ width: 28px; height: 20px; }
ul.profile-icons li.quote-icon	{ width: 54px; height: 20px; }
ul.profile-icons li.edit-icon	{ width: 42px; height: 20px; }

 /* ES Language Pack */
.pm-icon, .pm-icon a {
    background-image: url("./icon_contact_pm.gif");
}
.edit-icon, .edit-icon a {
	background-image: url("./icon_post_edit.gif");
}
.quote-icon, .quote-icon a {
	background-image: url("./icon_post_quote.gif");
}
.forwardpm-icon span {
    background-image: url("./button_pm_forward.gif");
}
.newpm-icon span {
    background-image: url("./button_pm_new.gif");
}
.pmreply-icon span {
    background-image: url("./button_pm_reply.gif");
}
.online {
    background-image: url("./icon_user_online.gif");
}
.locked-icon span {
    background-image: url("./button_topic_locked.gif");
}
.post-icon span {
	background-image: url("./button_topic_new.gif");
}
.reply-icon span {
	background-image: url("./button_topic_reply.gif");
}
*Imagine a signature super spectacular.*

Post Reply